sctp: xmit sctp packet always return no route error
Subsystems (3)
PATCH 1/1 sctp: xmit sctp packet always return no route error
Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.
--- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/output.c +1 -1
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst =dst_clone (tp->dst);skb_dst_set (nskb, dst); -if (dst) +if (!dst) goto no_route;/* Build the SCTP header. */
Signature · 1 line
1.6.2.2
Quoted 5 lines · Wei Yongjun
Commit 'net:
skb->dstaccessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.Signed-off-by Wei Yongjun <[email protected]>
Oops, sorry !
Quoted 17 lines
--- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)net/sctp/output.c +1
-1@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst =dst_clone (tp->dst);skb_dst_set (nskb, dst); -if (dst) +if (!dst) goto no_route;/* Build the SCTP header. */
Quoted 5 lines · Wei Yongjun
Commit 'net:
skb->dstaccessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.Signed-off-by Wei Yongjun <[email protected]>
Oh-oh!! Thanks for catching this.
-vlad
Quoted 17 lines
--- net/sctp/output.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)net/sctp/output.c +1
-1@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet) } dst =dst_clone (tp->dst);skb_dst_set (nskb, dst); -if (dst) +if (!dst) goto no_route;/* Build the SCTP header. */
From: Vlad Yasevich <[email protected]>
Date: Mon, 29 Jun 2009 09:12:54 -0400
Quoted 10 lines
Quoted 5 lines · Wei Yongjun
Commit 'net:
skb->dstaccessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.Signed-off-by Wei Yongjun <[email protected]>Oh-oh!! Thanks for catching this.
Acked-by Vlad Yasevich <[email protected]>
Applied.