Skip to contentSkip to conversation

sctp: xmit sctp packet always return no route error

PATCH Applied Wei Yongjun 4 participants 4 messages Jun 29, 2009 – Jun 30, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: xmit sctp packet always return no route error

Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.

---
 net/sctp/output.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/output.c +1 -1
index b764114..b94c211 100644
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
 	}
 	dst = dst_clone(tp->dst);
 	skb_dst_set(nskb, dst);
-	if (dst)
+	if (!dst)
 		goto no_route;
 
 	/* Build the SCTP header.  */
Signature · 1 line
1.6.2.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Wei Yongjun

Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.

Oops, sorry !

Quoted 17 lines
---
 net/sctp/output.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/output.c +1 -1
index b764114..b94c211 100644
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
 	}
 	dst = dst_clone(tp->dst);
 	skb_dst_set(nskb, dst);
-	if (dst)
+	if (!dst)
 		goto no_route;
 
 	/* Build the SCTP header.  */
Acked-by on v1 1/1
#2 lore raw
In reply to Wei Yongjun
Quoted 5 lines · Wei Yongjun

Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.

Oh-oh!! Thanks for catching this.

-vlad

Quoted 17 lines
---
 net/sctp/output.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/sctp/output.c +1 -1
index b764114..b94c211 100644
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
 	}
 	dst = dst_clone(tp->dst);
 	skb_dst_set(nskb, dst);
-	if (dst)
+	if (!dst)
 		goto no_route;
 
 	/* Build the SCTP header.  */
maintainer Applied
#3 lore raw

From: Vlad Yasevich <[email protected]>
Date: Mon, 29 Jun 2009 09:12:54 -0400

Quoted 10 lines
Quoted 5 lines · Wei Yongjun

Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5) broken the sctp protocol stack, the sctp packet can never be sent out after Eric Dumazet's patch, which have typo in the sctp code.

Oh-oh!! Thanks for catching this.

Applied.