Skip to contentSkip to conversation

tracing/syscall: remove redundant code

PATCH In review Xiao Guangrong 2 participants 2 messages Jun 29, 2009 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing/syscall: remove redundant code

No need to call trace_wake_up() explicitly because it's called in trace_current_buffer_unlock_commit().

---
 kernel/trace/trace_syscalls.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/trace/trace_syscalls.c +0 -2
index 5e57964..dd1ce2c 100644
@@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
 	syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
 
 	trace_current_buffer_unlock_commit(event, 0, 0);
-	trace_wake_up();
 }
 
 void ftrace_syscall_exit(struct pt_regs *regs)
@@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
 	entry->ret = syscall_get_return_value(current, regs);
 
 	trace_current_buffer_unlock_commit(event, 0, 0);
-	trace_wake_up();
 }
 
 static int init_syscall_tracer(struct trace_array *tr)
Signature · 1 line
1.6.1.2
Acked-by on v1 1/1
#1 lore raw
Quoted 31 lines · Xiao Guangrong

No need to call trace_wake_up() explicitly because it's called in trace_current_buffer_unlock_commit().

---
 kernel/trace/trace_syscalls.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/trace/trace_syscalls.c +0 -2
index 5e57964..dd1ce2c 100644
@@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
 	syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
 
 	trace_current_buffer_unlock_commit(event, 0, 0);
-	trace_wake_up();
 }
 
 void ftrace_syscall_exit(struct pt_regs *regs)
@@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
 	entry->ret = syscall_get_return_value(current, regs);
 
 	trace_current_buffer_unlock_commit(event, 0, 0);
-	trace_wake_up();
 }
 
 static int init_syscall_tracer(struct trace_array *tr)
Signature · 1 line
1.6.1.2

Thanks,