Skip to contentSkip to conversation

errno.h header -> asm-generic?

U-Boot Michal Simek 3 participants 4 messages Jun 30, 2009

lore
Share & tools
lore
#0 lore raw

Hi All,

I found that Microblaze miss errno.h file among some other minor fault which I want to fix.

Anyway I looked at errno.h header file for all arch which are in U-BOOT and I found that almost all arch use the same file that's why I think that will be good to create (maybe asm-generic) folder with these type of generic file.

What do you think guys?

Thanks,
Michal

Signature · 2 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
#1 lore raw

Hi Michal,

Quoted 9 lines · On Tuesday 30 June 2009 12:00:55 Michal Simek wrote:

I found that Microblaze miss errno.h file among some other minor fault which I want to fix.

Anyway I looked at errno.h header file for all arch which are in U-BOOT and I found that almost all arch use the same file that's why I think that will be good to create (maybe asm-generic) folder with these type of generic file.

What do you think guys?

Yes, I would welcome such a errno.h consolidation.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw
Quoted 6 lines · Stefan Roese

Hi Michal,

Quoted 3 lines · On Tuesday 30 June 2009 12:00:55 Michal Simek wrote:

I found that Microblaze miss errno.h file among some other minor fault which I want to fix.

Quoted 8 lines
Quoted 6 lines

Anyway I looked at errno.h header file for all arch which are in U-BOOT and I found that almost all arch use the same file that's why I think that will be good to create (maybe asm-generic) folder with these type of generic file.

What do you think guys?

Yes, I would welcome such a errno.h consolidation.

ditto

Best Regards,
J.

#3 lore raw
Quoted 7 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 6 lines · Stefan Roese

Hi Michal,

Quoted 3 lines · On Tuesday 30 June 2009 12:00:55 Michal Simek wrote:

I found that Microblaze miss errno.h file among some other minor fault which I want to fix.

Quoted 9 lines
Quoted 7 lines
Quoted 6 lines

Anyway I looked at errno.h header file for all arch which are in U-BOOT and I found that almost all arch use the same file that's why I think that will be good to create (maybe asm-generic) folder with these type of generic file.

What do you think guys?

Yes, I would welcome such a errno.h consolidation.

ditto

I have just sent patch to mailing list.

Some my comments:

MIPS has incompatible errno.h that's why I don't remove it - it is up to custodian.

NIOS, NIOS2, i386 don't have errno.h is asm folder -> this mean for me that they don't need it. If yes, let me know.

Some archs define EDEADLOCK to 58 and some as EDEADLK. I looked at Linux kernel and there is EDEADLK that's why I added this implementation is asm-generic.
#define EDEADLOCK 58 /* File locking deadlock error */
#define EDEADLOCK EDEADLK

Some arch defined these 5 macros below - they are not used in U-BOOT that's why I removed them.

/* Should never be seen by user programs */
#define ERESTARTSYS 512
#define ERESTARTNOINTR 513
#define ERESTARTNOHAND 514 /* restart if no handler.. */
#define ENOIOCTLCMD 515 /* No ioctl command */

#define _LAST_ERRNO 515

Please test this change carefully. If you have any problem let me know.

Thanks,
Michal

Quoted 2 lines

Best Regards,
J.

Signature · 2 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854