Skip to contentSkip to conversation

libata: remove spindown skipping and warning

PATCH In review Tejun Heo 2 participants 2 messages Jul 3, 2009 – Jul 29, 2009

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: remove spindown skipping and warning

This was a hack to give userland shutdown tools time to drop manual spindown. All popular distros updated quite some time ago and the due is well passed. Drop it.

Cc Jaswinder Singh Rajput <[email protected]>
---
 Documentation/feature-removal-schedule.txt |   18 ----------
 drivers/ata/libata-scsi.c                  |   51 -----------------------------
 include/linux/libata.h                     |    1 
 3 files changed, 70 deletions(-)
Documentation/feature-removal-schedule.txt +0 -18
index de491a3..519c881 100644
@@ -192,24 +192,6 @@ Who:	Len Brown <[email protected]>
 
 ---------------------------
 
-What: libata spindown skipping and warning
-When: Dec 2008
-Why:  Some halt(8) implementations synchronize caches for and spin
-      down libata disks because libata didn't use to spin down disk on
-      system halt (only synchronized caches).
-      Spin down on system halt is now implemented.  sysfs node
-      /sys/class/scsi_disk/h:c:i:l/manage_start_stop is present if
-      spin down support is available.
-      Because issuing spin down command to an already spun down disk
-      makes some disks spin up just to spin down again, libata tracks
-      device spindown status to skip the extra spindown command and
-      warn about it.
-      This is to give userspace tools the time to get updated and will
-      be removed after userspace is reasonably updated.
-Who:  Tejun Heo <[email protected]>
-
----------------------------
-
 What:	i386/x86_64 bzImage symlinks
 When:	April 2010
 
drivers/ata/libata-scsi.c +0 -51

69 lines not on this page · raw message

include/linux/libata.h +0 -1
index 3d501db..36b5470 100644
@@ -143,7 +143,6 @@ enum {
 
 	ATA_DFLAG_PIO		= (1 << 12), /* device limited to PIO mode */
 	ATA_DFLAG_NCQ_OFF	= (1 << 13), /* device limited to non-NCQ mode */
-	ATA_DFLAG_SPUNDOWN	= (1 << 14), /* XXX: for spindown_compat */
 	ATA_DFLAG_SLEEPING	= (1 << 15), /* device is sleeping */
 	ATA_DFLAG_DUBIOUS_XFER	= (1 << 16), /* data transfer not verified */
 	ATA_DFLAG_NO_UNLOAD	= (1 << 17), /* device doesn't support unload */
#1 lore raw
Quoted 11 lines · Tejun Heo

This was a hack to give userland shutdown tools time to drop manual spindown. All popular distros updated quite some time ago and the due is well passed. Drop it.

Cc Jaswinder Singh Rajput <[email protected]>
---
 Documentation/feature-removal-schedule.txt |   18 ----------
 drivers/ata/libata-scsi.c                  |   51 -----------------------------
 include/linux/libata.h                     |    1 
 3 files changed, 70 deletions(-)

applied - yay!