Skip to contentSkip to conversation

x86 shadow: disable fast np path in OOS.

PATCH In review Gianluca Guida 2 participants 2 messages Jul 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86 shadow: disable fast np path in OOS.

As discussed, this patch disables fast NP path when OOS is enabled.

Signed off by: Gianluca Guida <[email protected]>

xen/arch/x86/mm/shadow/multi.c +2 -0
diff -r 7397608bce87 xen/arch/x86/mm/shadow/multi.c
@@ -494,11 +494,13 @@
 
     if ( unlikely(!(gflags & _PAGE_PRESENT)) )
     {
+#if !(SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
         /* If a guest l1 entry is not present, shadow with the magic 
          * guest-not-present entry. */
         if ( level == 1 )
             *sp = sh_l1e_gnp();
         else 
+#endif /* !OOS */
             *sp = shadow_l1e_empty();
         goto done;
     }

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 3 lines · Gianluca Guida

As discussed, this patch disables fast NP path when OOS is enabled.

Signed off by: Gianluca Guida <[email protected]>

Both of your patches look good to me. I can't think of a scenario where the same problem would occur again with your patches, and with them applied, I can't reproduce the problem anymore (on a setup that reproduced it reliably before).

Thanks for the quick fix,

- Frank