Skip to contentSkip to conversation

tracing: fix missed type name

PATCH New Lai Jiangshan 1 participant 1 message Jul 8, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: fix missed type name

events/SYSTEM/TP/format does not contain enough information for __dynamic_array or __string. It misses the type name.

__data_loc ITEM ==> __data_loc TYPE[] ITEM

Then "__data_loc" is a storage modifier like "register" or "static".

Two additional fixes, it's also important for user.

__data_loc [TYPE] ==> __data_loc TYPE[]

TYPE ITEM[LEN] ==> TYPE[LEN] ITEM

---

include/trace/ftrace.h +3 -3
index 1867553..8df5b20 100644
@@ -111,7 +111,7 @@
 
 #undef __array
 #define __array(type, item, len)						\
-	ret = trace_seq_printf(s, "\tfield:" #type " " #item "[" #len "];\t"	\
+	ret = trace_seq_printf(s, "\tfield:" #type "[" #len "] " #item ";\t"	\
 			       "offset:%u;\tsize:%u;\n",		\
 			       (unsigned int)offsetof(typeof(field), item), \
 			       (unsigned int)sizeof(field.item));	\
@@ -120,7 +120,7 @@
 
 #undef __dynamic_array
 #define __dynamic_array(type, item, len)				       \
-	ret = trace_seq_printf(s, "\tfield:__data_loc " #item ";\t"	       \
+	ret = trace_seq_printf(s, "\tfield:__data_loc " #type "[] " #item ";\t"\
 			       "offset:%u;\tsize:%u;\n",		       \
 			       (unsigned int)offsetof(typeof(field),	       \
 					__data_loc_##item),		       \
@@ -279,7 +279,7 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags)	\
 
 #undef __dynamic_array
 #define __dynamic_array(type, item, len)				       \
-	ret = trace_define_field(event_call, "__data_loc" "[" #type "]", #item,\
+	ret = trace_define_field(event_call, "__data_loc " #type "[]", #item,  \
 				offsetof(typeof(field), __data_loc_##item),    \
 				 sizeof(field.__data_loc_##item), 0);