83xx, kmeter1: added NAND support
PATCH 3/3 83xx, kmeter1: added NAND support
--- board/keymile/kmeter1/Makefile | 2 +- board/keymile/kmeter1/nand.c | 153 ++++++++++++++++++++++++++++++++++++++++ include/configs/kmeter1.h | 5 ++ 3 files changed, 159 insertions(+), 1 deletions(-) create mode 100644 board/keymile/kmeter1/nand.c
board/keymile/kmeter1/Makefile +1 -1
@@ -28,7 +28,7 @@ endif LIB = $(obj)lib$(BOARD).a -COBJS += $(BOARD).o ../common/common.o +COBJS += $(BOARD).o ../common/common.o nand.o SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) OBJS := $(addprefix $(obj),$(COBJS))
board/keymile/kmeter1/nand.c new file +153 -0
153 lines not on this page · raw message
include/configs/kmeter1.h +5 -0
@@ -324,6 +324,11 @@#define CONFIG_SYS_DTT_HYSTERESIS 3#define CONFIG_SYS_DTT_BUS_NUM (CONFIG_SYS_MAX_I2C_BUS) +#if defined(CONFIG_CMD_NAND ) +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define CONFIG_SYS_NAND_BASE CONFIG_SYS_PIGGY_BASE +#endif +#if defined(CONFIG_PCI )#define CONFIG_CMD_PCI #endif
Signature · 5 lines
1.6.0.6 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 3/3 83xx, kmeter1: added NAND support
Hi Heiko,
Quoted 4 lines · On Thursday 09 July 2009 12:04:41 Heiko Schocher wrote:
Signed-off-by Heiko Schocher <[email protected]>--- board/keymile/kmeter1/Makefile | 2 +-
board/keymile/kmeter1/nand.c
I suggest to move this NAND driver into the drivers/mtd/nand directory (e.g. drivers/mtd/nand/kmeter1_nand.c). We try to collect all drivers here. This makes maintenance easier.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
PATCH 3/3 83xx, kmeter1: added NAND support
Hello Stefan,
Quoted 9 lines · Stefan Roese
Quoted 4 lines · On Thursday 09 July 2009 12:04:41 Heiko Schocher wrote:
Signed-off-by Heiko Schocher <[email protected]>--- board/keymile/kmeter1/Makefile | 2 +-
board/keymile/kmeter1/nand.cI suggest to move this NAND driver into the
drivers/mtd/nanddirectory (e.g.drivers/mtd/nand/kmeter1_nand.c). We try to collect all drivers here. This makes maintenance easier.
Hmm... this is not a "nand driver", just some board specific functions. Should this go really in "drivers/mtd/nand"?
bye
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH 3/3 83xx, kmeter1: added NAND support
Quoted 9 lines · On Thursday 09 July 2009 16:59:02 Heiko Schocher wrote:
Quoted 6 lines
Quoted 2 lines
board/keymile/kmeter1/Makefile | 2 +-
board/keymile/kmeter1/nand.cI suggest to move this NAND driver into the
drivers/mtd/nanddirectory (e.g.drivers/mtd/nand/kmeter1_nand.c). We try to collect all drivers here. This makes maintenance easier.Hmm... this is not a "nand driver", just some board specific functions.
Yes, it's still a NAND driver. Please take a look at a few of the other "drivers" in this directory. E.g. drivers/mtd/nand/atmel_nand.c. You will see that those are similar to your board specific driver. Implementing the HW- interface for the NAND infrastructure.
Quoted 1 line
Should this go really in "
drivers/mtd/nand"?
Yes, please.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================