Skip to contentSkip to conversation

arlan: inverted logic?

PATCH New Roel Kluin 1 participant 1 message Jul 12, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 arlan: inverted logic?

Inverted logic

Signed-off-by Roel Kluin <[email protected]>

---
Usually the inverted occurs see:

s="[[:space:]]*"
em='!'

git grep -E -n -A1 "if$s\($s$em?${s}netif_running$s\(" | grep -B1 "[-]EBUSY" | less

Is my patch correct? please review.

drivers/net/wireless/arlan-main.c +1 -1
index d84caf1..4ac519f 100644
@@ -1022,7 +1022,7 @@ static int arlan_mac_addr(struct net_device *dev, void *p)
 	ARLAN_DEBUG_ENTRY("arlan_mac_addr");
 	return -EINVAL;
 
-	if (!netif_running(dev))
+	if (netif_running(dev))
 		return -EBUSY;
 	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);