Skip to contentSkip to conversation

atlx: duplicate testing of MCAST flag

PATCH Applied Roel Kluin 3 participants 3 messages Jul 12, 2009 – Jul 13, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 atlx: duplicate testing of MCAST flag

Fix duplicate testing of MCAST flag

Signed-off-by Roel Kluin <[email protected]>

---
I think the first should be UCAST, correct?

drivers/net/atlx/atl2.c +1 -1
index c734b19..204db96 100644
@@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
 	if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
 		return -EOPNOTSUPP;
 
-	if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
+	if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
 		return -EOPNOTSUPP;
 
 	/* these settings will always override what we currently have */
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Roel Kluin

Fix duplicate testing of MCAST flag

Signed-off-by Roel Kluin <[email protected]>

---
I think the first should be UCAST, correct?

drivers/net/atlx/atl2.c +0 -0
index c734b19..204db96 100644

drivers/net/atlx/atl2.c static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol) · line 2077

Quoted 8 lines
drivers/net/atlx/atl2.c +1 -1
@@ -2071,7 +2071,7 @@ static int atl2_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
        if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE))
                return -EOPNOTSUPP;
 
-       if (wol->wolopts & (WAKE_MCAST|WAKE_BCAST|WAKE_MCAST))
+       if (wol->wolopts & (WAKE_UCAST | WAKE_BCAST | WAKE_MCAST))
                return -EOPNOTSUPP;
 
        /* these settings will always override what we currently have */
Acked-by Jay Cliburn <[email protected]>