radio-si470x: separate usb and i2c interface
v2 cover radio-si470x: separate usb and i2c interface
Hi, all
I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
The patches is updated to version 2.
I have a board with Silicon Labs si4709 chip using the i2c interface, but the radio-si470x is only support usb interface currently. I posted about separating usb and i2c interface in radio-si470x the past.
http://www.mail-archive.com/[email protected]/msg02483.html
Tobias informed me the base code for seperating at
http://linuxtv.org/hg/~tlorenz/v4l-dvb of Tobias repository in above mail, i based on it, but it cannot find now at Tobias repository.
The patch 1/4 is for separating common and usb code.
The patch 2/4 is about using dev_* macro instead of printk. The patch 3/4 is about adding disconnect check function for i2c interface. The patch 4/4 is for supporting si470x i2c interface.
Please review, thank you.
Hi,
Quoted 2 lines
I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
The patches is updated to version 2.
The patchset looks good. I'll give my feedback in the following mails.
Quoted 3 lines
Tobias informed me the base code for seperating at
http://linuxtv.org/hg/~tlorenz/v4l-dvb of Tobias repository in above mail, i based on it, but it cannot find now at Tobias repository.
Before sending a pull request, I usually clean up the archive from any other patches.
But nevertheless, you and me still have the I2C patches. They now reached a quality to finally bring them in the kernel. Good work.
Quoted 4 lines
The patch 1/4 is for separating common and usb code.
The patch 2/4 is about using dev_* macro instead of printk. The patch 3/4 is about adding disconnect check function for i2c interface. The patch 4/4 is for supporting si470x i2c interface.
Bye,
Toby
Hi,
Quoted 7 lines · Tobias Lorenz
Hi,
Quoted 2 lines
I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
The patches is updated to version 2.The patchset looks good. I'll give my feedback in the following mails.
Quoted 8 lines
Quoted 3 lines
Tobias informed me the base code for seperating at
http://linuxtv.org/hg/~tlorenz/v4l-dvb of Tobias repository in above mail, i based on it, but it cannot find now at Tobias repository.Before sending a pull request, I usually clean up the archive from any other patches.
But nevertheless, you and me still have the I2C patches. They now reached a quality to finally bring them in the kernel. Good work.
Thanks.
I am concerned about one thing. I cannot test the si470x usb radio driver because i don't have the si470x usb radio device, so i believe you would have probably tested it.
Quoted 8 lines
Quoted 4 lines
The patch 1/4 is for separating common and usb code.
The patch 2/4 is about using dev_* macro instead of printk. The patch 3/4 is about adding disconnect check function for i2c interface. The patch 4/4 is for supporting si470x i2c interface.Bye,
Toby
Hi,
Quoted 3 lines
I am concerned about one thing. I cannot test the si470x usb radio driver because i don't have the si470x usb radio device, so i believe you would have probably tested it.
It is working. I tested it with the most common radio applications and with some RDS decoders.
As the I2C part is working, I will send Mauro a pull request.
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
The patch 1/4 is for separating common and usb code.
The patch 2/4 is about using dev_* macro instead of printk. The patch 3/4 is about adding disconnect check function for i2c interface. The patch 4/4 is for supporting si470x i2c interface.
Bye,
Toby