Fix leaked config override mempool.
PATCH 1/1 Fix leaked config override mempool.
Fix leaked config override mempool.
pvs --config 'global { units = "<" }'
Invalid units specification
Updated config file invalid. Aborting.
causes in old code
Segmentation fault
and now memory leak :-)
Fix it by properly releasing overrided config in lvm_run_command if refresh_toolcontext() fails.
Signed-off-by Milan Broz <[email protected]>
--- tools/lvmcmdline.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
tools/lvmcmdline.c +2 -1
@@ -993,7 +993,8 @@ int lvm_run_command(struct cmd_context *cmd, int argc, char **argv)/* Reinitialise various settings inc. logging, filters */ if (!refresh_toolcontext (cmd)) {log_error ("Updated config file invalid. Aborting." ); -return ECMD_FAILED ; + ret =ECMD_FAILED ; + goto out; } }