Skip to contentSkip to conversation

ARM Cortex A8: Move OMAP3 specific reset handler

PATCH New Minkyu Kang 4 participants 4 messages Jul 20, 2009 – Jul 22, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM Cortex A8: Move OMAP3 specific reset handler

Because of the reset_cpu is soc specific, should be move to soc

---
 cpu/arm_cortexa8/omap3/Makefile |    1 +
 cpu/arm_cortexa8/omap3/reset.S  |   36 ++++++++++++++++++++++++++++++++++++
 cpu/arm_cortexa8/start.S        |   14 --------------
 3 files changed, 37 insertions(+), 14 deletions(-)
 create mode 100644 cpu/arm_cortexa8/omap3/reset.S
cpu/arm_cortexa8/omap3/Makefile +1 -0
index 1fbd0dc..eef165c 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	=  $(obj)lib$(SOC).a
 
 SOBJS	:= lowlevel_init.o
+SOBJS	+= reset.o
 
 COBJS	+= board.o
 COBJS	+= cache.o
cpu/arm_cortexa8/omap3/reset.S new file +36 -0
new file mode 100644
index 0000000..a53c408
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2009 Samsung Electronics.
+ * Minkyu Kang <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.global reset_cpu
+reset_cpu:
+	ldr	r1, rstctl			@ get addr for global reset
+						@ reg
+	mov	r3, #0x2			@ full reset pll + mpu
+	str	r3, [r1]			@ force reset
+	mov	r0, r0
+_loop_forever:
+	b	_loop_forever
+rstctl:
+	.word	PRM_RSTCTRL
cpu/arm_cortexa8/start.S +0 -14
index 66b4820..6bd6552 100644
@@ -500,17 +500,3 @@ finished_inval:
 						@ but we compile with armv5
 
 	ldmfd	r13!, {r0 - r5, r7, r9 - r12, pc}
-
-
-	.align	5
-.global reset_cpu
-reset_cpu:
-	ldr	r1, rstctl			@ get addr for global reset
-						@ reg
-	mov	r3, #0x2			@ full reset pll + mpu
-	str	r3, [r1]			@ force reset
-	mov	r0, r0
-_loop_forever:
-	b	_loop_forever
-rstctl:
-	.word	PRM_RSTCTRL
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 ARM Cortex A8: Move OMAP3 specific reset handler

Hi,

It's already discussed. Actually it's required for adding new S5PC1xx series based on arm cortext8.
Please apply it.

Thank you,
Kyungmin Park

Quoted 94 lines · Minkyu Kang

Because of the reset_cpu is soc specific, should be move to soc

---

?cpu/arm_cortexa8/omap3/Makefile | ? ?1 +
?cpu/arm_cortexa8/omap3/reset.S ?| ? 36 ++++++++++++++++++++++++++++++++++++
?cpu/arm_cortexa8/start.S ? ? ? ?| ? 14 --------------

?3 files changed, 37 insertions(+), 14 deletions(-) ?create mode 100644 cpu/arm_cortexa8/omap3/reset.S

cpu/arm_cortexa8/omap3/Makefile +0 -0
index 1fbd0dc..eef165c 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk

?LIB ? ?= ?$(obj)lib$(SOC).a

?SOBJS ?:= lowlevel_init.o
+SOBJS ?+= reset.o

?COBJS ?+= board.o
?COBJS ?+= cache.o

cpu/arm_cortexa8/omap3/reset.S new file +36 -0
new file mode 100644
index 0000000..a53c408
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2009 Samsung Electronics.
+ * Minkyu Kang <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.global reset_cpu
+reset_cpu:
+ ? ? ? ldr ? ? r1, rstctl ? ? ? ? ? ? ? ? ? ? ?@ get addr for global reset
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? @ reg
+ ? ? ? mov ? ? r3, #0x2 ? ? ? ? ? ? ? ? ? ? ? ?@ full reset pll + mpu
+ ? ? ? str ? ? r3, [r1] ? ? ? ? ? ? ? ? ? ? ? ?@ force reset
+ ? ? ? mov ? ? r0, r0
+_loop_forever:
+ ? ? ? b ? ? ? _loop_forever
+rstctl:
+ ? ? ? .word ? PRM_RSTCTRL
cpu/arm_cortexa8/start.S +0 -0
index 66b4820..6bd6552 100644
@@ -500,17 +500,3 @@ finished_inval:

? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?@ but we compile with armv5

? ? ? ?ldmfd ? r13!, {r0 - r5, r7, r9 - r12, pc}

cpu/arm_cortexa8/start.S +0 -15
-
-
- ? ? ? .align ?5
-.global reset_cpu
-reset_cpu:
- ? ? ? ldr ? ? r1, rstctl ? ? ? ? ? ? ? ? ? ? ?@ get addr for global reset
- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? @ reg
- ? ? ? mov ? ? r3, #0x2 ? ? ? ? ? ? ? ? ? ? ? ?@ full reset pll + mpu
- ? ? ? str ? ? r3, [r1] ? ? ? ? ? ? ? ? ? ? ? ?@ force reset
- ? ? ? mov ? ? r0, r0
-_loop_forever:
- ? ? ? b ? ? ? _loop_forever
-rstctl:
- ? ? ? .word ? PRM_RSTCTRL
--

1.5.4.3
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH 1/1 ARM Cortex A8: Move OMAP3 specific reset handler

In reply to Minkyu Kang
Quoted 1 line · Minkyu Kang

Because of the reset_cpu is soc specific, should be move to soc

Thanks, looks fine for me.

For the archives, this makes

http://lists.denx.de/pipermail/u-boot/2009-May/053490.html

obsolete.

Dirk

Quoted 85 lines
---
 cpu/arm_cortexa8/omap3/Makefile |    1 +
 cpu/arm_cortexa8/omap3/reset.S  |   36 ++++++++++++++++++++++++++++++++++++
 cpu/arm_cortexa8/start.S        |   14 --------------
 3 files changed, 37 insertions(+), 14 deletions(-)
 create mode 100644 cpu/arm_cortexa8/omap3/reset.S
cpu/arm_cortexa8/omap3/Makefile +1 -0
index 1fbd0dc..eef165c 100644
@@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
 LIB	=  $(obj)lib$(SOC).a
 
 SOBJS	:= lowlevel_init.o
+SOBJS	+= reset.o
 
 COBJS	+= board.o
 COBJS	+= cache.o
cpu/arm_cortexa8/omap3/reset.S new file +36 -0
new file mode 100644
index 0000000..a53c408
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2009 Samsung Electronics.
+ * Minkyu Kang <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.global reset_cpu
+reset_cpu:
+	ldr	r1, rstctl			@ get addr for global reset
+						@ reg
+	mov	r3, #0x2			@ full reset pll + mpu
+	str	r3, [r1]			@ force reset
+	mov	r0, r0
+_loop_forever:
+	b	_loop_forever
+rstctl:
+	.word	PRM_RSTCTRL
cpu/arm_cortexa8/start.S +0 -14
index 66b4820..6bd6552 100644
@@ -500,17 +500,3 @@ finished_inval:
 						@ but we compile with armv5
 
 	ldmfd	r13!, {r0 - r5, r7, r9 - r12, pc}
-
-
-	.align	5
-.global reset_cpu
-reset_cpu:
-	ldr	r1, rstctl			@ get addr for global reset
-						@ reg
-	mov	r3, #0x2			@ full reset pll + mpu
-	str	r3, [r1]			@ force reset
-	mov	r0, r0
-_loop_forever:
-	b	_loop_forever
-rstctl:
-	.word	PRM_RSTCTRL
#3 lore raw

PATCH 1/1 ARM Cortex A8: Move OMAP3 specific reset handler

In reply to Minkyu Kang
Quoted 10 lines · Minkyu Kang

Because of the reset_cpu is soc specific, should be move to soc

---
 cpu/arm_cortexa8/omap3/Makefile |    1 +
 cpu/arm_cortexa8/omap3/reset.S  |   36 ++++++++++++++++++++++++++++++++++++
 cpu/arm_cortexa8/start.S        |   14 --------------
 3 files changed, 37 insertions(+), 14 deletions(-)
 create mode 100644 cpu/arm_cortexa8/omap3/reset.S

applied to u-boot-arm

Best Regards,
J.