Skip to contentSkip to conversation

hal-0.5.12 requires blkid >= 1.43

RFC In review Ulf Samuelsson 4 participants 8 messages Jul 21, 2009

lore
Share & tools
lore
#0 lore raw

RFC 1/1 hal-0.5.12 requires blkid >= 1.43

hal does not build when bitbaking gpe-image,since blkid is 1.41.8 and hal requires >= 1.43.
1.41.8 seems to be the latest!
The attached patch fixes configure and configure.in in the hal

First the patch to the recipe.

recipes/hal/hal_0.5.12.bb +4 -0
index b6531e8..155c2e3 100644
@@ -2,6 +2,10 @@ require hal.inc
 
 DEFAULT_PREFERENCE = "-1"
 
+PR = "r1"
+
+SRC_URI += " file://hal-0.5.12-blkid-1.41.patch;patch=1"
+
 # The following code finds the right linux/input.h,
 # which also works with external-toolchain/SDK
 do_configure() {

---
Then the patch which should reside in the "recipe/hal/hal-0.5.12/hal-0.5.12-blkid-1.41.patch"

configure 2009-07-21 10:06:27.000000000 +0200 renamed from configure 2009-07-21 10:02:37.000000000 +0200 +1 -1
diff -urN a/configure b/configure
@@ -2791,7 +2791,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage
configure.in 2009-07-21 10:06:51.000000000 +0200 renamed from configure.in 2009-05-10 21:43:52.000000000 +0200 +1 -1
diff -urN a/configure.in b/configure.in
@@ -13,7 +13,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage

Comments?

Best Regards
Ulf Samuelsson

configure +1 -1
diff -urN a/configure b/configure
@@ -2791,7 +2791,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage
configure.in +1 -1
diff -urN a/configure.in b/configure.in
@@ -13,7 +13,7 @@
 
 glib_module="glib-2.0 >= 2.10.0 gobject-2.0 > 2.10.0 dbus-glib-1 >= 0.61"
 dbus_module="dbus-1 >= 0.61"
-blkid_module="blkid >= 1.43"
+blkid_module="blkid >= 1.41"
 polkit_module="polkit >= 0.5"
 
 # libtool versioning - this applies to libhal and libhal-storage
#1 lore raw
Quoted 26 lines · Ulf Samuelsson

diff -urN a/configure b/configure

configure 2009-07-21 10:06:27.000000000 +0200 renamed from configure 2009-07-21 10:02:37.000000000 +0200 +1 -1
@@ -2791,7 +2791,7 @@
 
  glib_module="glib-2.0>= 2.10.0 gobject-2.0>  2.10.0 dbus-glib-1>= 0.61"
  dbus_module="dbus-1>= 0.61"
-blkid_module="blkid>= 1.43"
+blkid_module="blkid>= 1.41"
  polkit_module="polkit>= 0.5"
 
  # libtool versioning - this applies to libhal and libhal-storage

diff -urN a/configure.in b/configure.in

configure.in 2009-07-21 10:06:51.000000000 +0200 renamed from configure.in 2009-05-10 21:43:52.000000000 +0200 +1 -1
@@ -13,7 +13,7 @@
 
  glib_module="glib-2.0>= 2.10.0 gobject-2.0>  2.10.0 dbus-glib-1>= 0.61"
  dbus_module="dbus-1>= 0.61"
-blkid_module="blkid>= 1.43"
+blkid_module="blkid>= 1.41"
  polkit_module="polkit>= 0.5"
 
  # libtool versioning - this applies to libhal and libhal-storage
Quoted 1 line

Comments?

configure gets generated from configure.in, so you only have to patch one file. And please use git-format-patch to make a single patch next time.

Anyway, I solved it in a different way.

regards,

Koen

#2 lore raw
In reply to Ulf Samuelsson

Hi,

Quoted 1 line · Ulf Samuelsson

Comments?

even if it looks strange... I agree. Very unlikely that the hal maintainers meant to depend on a future release of e2fsprogs.

Greetings

Florian

Signature · 5 lines
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        [email protected]
                                        http://www.kernelconcepts.de/en
#5 lore raw
In reply to Ulf Samuelsson
Quoted 4 lines · Ulf Samuelsson

hal does not build when bitbaking gpe-image,since blkid is 1.41.8 and hal requires >= 1.43.
1.41.8 seems to be the latest!
The attached patch fixes configure and configure.in in the hal

I think the idea is that you're meant to use libblkid from util-linux-ng. I've no idea what the difference is, though: it's possible that 1.41.8 would indeed work correctly. I guess you'd have to ask the hal h4x0rs why they selected 1.43 as the minimum version to be sure.

p.

#3 lore raw
In reply to Florian Boor
Quoted 8 lines · Florian Boor

Hi,

Quoted 1 line · Ulf Samuelsson

Comments?

even if it looks strange... I agree. Very unlikely that the hal maintainers meant to depend on a future release of e2fsprogs.

The util-linux-ng people made it go backwards when moving it from e2fsprogs to util-linux-ng. Upstream error, but relatively harmless as the resuling package gets 2.16 as PV.

regards,

Koen

#4 lore raw
Quoted 7 lines · Koen Kooi
Quoted 6 lines · Florian Boor

Hi,

Quoted 1 line · Ulf Samuelsson

Comments?

Quoted 7 lines
Quoted 3 lines

even if it looks strange... I agree. Very unlikely that the hal maintainers
meant to depend on a future release of e2fsprogs.

The util-linux-ng people made it go backwards when moving it from e2fsprogs to util-linux-ng. Upstream error, but relatively harmless as the resuling package gets 2.16 as PV.

I am confused, ignore me

#6 lore raw
In reply to Phil Blundell

Phil Blundell skrev:

On Tue, 2009-07-21 at 10:33 +0200, Ulf Samuelsson wrote:

hal does not build when bitbaking gpe-image,since blkid is 1.41.8 and hal requires >= 1.43.
1.41.8 seems to be the latest!
The attached patch fixes configure and configure.in in the hal

I think the idea is that you're meant to use libblkid from util-linux-ng. I've no idea what the difference is, though: it's possible that 1.41.8 would indeed work correctly. I guess you'd have to ask the hal h4x0rs why they selected 1.43 as the minimum version to be sure.

p.

I did not do anything special, just "bitbake gpe-image".

Looks like "gpe-image" should be updated to use "util-linux-ng" instead of my proposed patch.

--
Best Regards
Ulf Samuelsson

#7 lore raw
Quoted 2 lines · Ulf Samuelsson

Looks like "gpe-image" should be updated to use "util-linux-ng" instead of my proposed patch.

I don't think this is a gpe-image issue as such; it sounds more like a case of wrong dependencies on the hal package.

p.