Read buffer overflow

PATCH New Roel Kluin 1 participant 1 message Jul 23, 2009 Media (V4L/DVB)

lore

Share & tools

lore

Roel Kluin

author

2009-07-23 21:14 UTC #0 lore raw

PATCH 1/1 Read buffer overflow

parport[n] is checked before n < MAX_CAMS

Signed-off-by Roel Kluin <[email protected]>

---
probably harmless

drivers/media/video/bw-qcam.c +1 -1

index 10dbd4a..9e39bc5 100644
@@ -992,7 +992,7 @@ static int accept_bwqcam(struct parport *port)
 
 	if (parport[0] && strncmp(parport[0], "auto", 4) != 0) {
 		/* user gave parport parameters */
-		for(n=0; parport[n] && n<MAX_CAMS; n++){
+		for (n = 0; n < MAX_CAMS && parport[n]; n++) {
 			char *ep;
 			unsigned long r;
 			r = simple_strtoul(parport[n], &ep, 0);