Skip to contentSkip to conversation

fix find_free_dev_extent

PATCH New Yan Zheng 1 participant 1 message Jul 24, 2009 Btrfs file system

lore
Share & tools
lore

Yan Zheng

author
#0 lore raw

PATCH 1/1 fix find_free_dev_extent

find_free_dev_extent does not properly handle the case:
device is not complete free, and there is a free extent at the beginning of the device.

---

fs/btrfs/volumes.c +7 -3
diff -urp 1/fs/btrfs/volumes.c 2/fs/btrfs/volumes.c
@@ -758,9 +758,13 @@ static noinline int find_free_dev_extent
 	ret = btrfs_search_slot(trans, root, &key, path, 0, 0);
 	if (ret < 0)
 		goto error;
-	ret = btrfs_previous_item(root, path, 0, key.type);
-	if (ret < 0)
-		goto error;
+	if (ret > 0) {
+		ret = btrfs_previous_item(root, path, key.objectid, key.type);
+		if (ret < 0)
+			goto error;
+		if (ret > 0)
+			start_found = 1;
+	}
 	l = path->nodes[0];
 	btrfs_item_key_to_cpu(l, &key, path->slots[0]);
 	while (1) {