xfstests: actually hook up 198, make it generic
PATCH 1/1 xfstests: actually hook up 198, make it generic
Not entirely sure how I managed this, but 198 was not in groups so was never run - and wasn't in the makefile, so was never built. Oops.
Fix that up, make it a generic test, and move it to the aio-dio-regress subdir.
---
198 +2 -2
@@ -43,7 +43,7 @@ _cleanup() . ./common.filter # This should actually run on anything that supports O_DIRECT + AIO... -_supported_fs xfs +_supported_fs generic _supported_os Linux echo "Silence is golden."
@@ -52,7 +52,7 @@ echo "Silence is golden." rm -f $seq.full rm -f "$TEST_DIR/aiodio_sparse*" -$here/src/aiodio_sparse2 "$TEST_DIR/aiodio_sparse" +$here/src/aio-dio-regress/aiodio_sparse2 "$TEST_DIR/aiodio_sparse" status=$? exit
group +1 -0
@@ -307,6 +307,7 @@ prealloc 195 ioctl dump auto quick 196 quota auto quick 197 dir auto quick +198 aio auto quick 199 mount auto quick 200 mount auto quick 201 metadata auto quick
src/aio-dio-regress/aiodio_sparse2.c new file +384 -0
384 lines not on this page · raw message
src/aiodio_sparse2.c deleted +0 -366
366 lines not on this page · raw message
198 +2 -2
@@ -43,7 +43,7 @@ _cleanup() . ./common.filter # This should actually run on anything that supports O_DIRECT + AIO... -_supported_fs xfs +_supported_fs generic _supported_os Linux echo "Silence is golden."
@@ -52,7 +52,7 @@ echo "Silence is golden." rm -f $seq.full rm -f "$TEST_DIR/aiodio_sparse*" -$here/src/aiodio_sparse2 "$TEST_DIR/aiodio_sparse" +$here/src/aio-dio-regress/aiodio_sparse2 "$TEST_DIR/aiodio_sparse" status=$? exit
group +1 -0
@@ -307,6 +307,7 @@ prealloc 195 ioctl dump auto quick 196 quota auto quick 197 dir auto quick +198 aio auto 199 mount auto quick 200 mount auto quick 201 metadata auto quick
src/aio-dio-regress/aiodio_sparse2.c new file +384 -0
384 lines not on this page · raw message
src/aiodio_sparse2.c deleted +0 -384
384 lines not on this page · raw message
- }
-
- strncpy(filename, argv[argc-1], PATH_MAX);
-
- /*
- * Create some dirty free blocks by allocating, writing, syncing,
- * and then unlinking and freeing.
- */
- dirty_freeblocks(filename, filesize);
-
- /*
- * Parent write to a hole in a file using async direct i/o
- */
-
- aiodio_sparse(filename, alignment, writesize, filesize, num_aio, step, sparse, direct, keep);
-
- return 0;
-}
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Eric Sandeen
Not entirely sure how I managed this, but 198 was not in groups so was never run - and wasn't in the makefile, so was never built. Oops.
Fix that up, make it a generic test, and move it to the aio-dio-regress subdir.
Hah, great one.
Review
Quoted 3 lines
# This should actually run on anything that supports
O_DIRECT+ AIO...(quoted diff) +1
-1-_supported_fs xfs +_supported_fs generic
maybe also remove that comment now that it's generic.
src/aio-dio-regress/aiodio_sparse2.c line 7
Quoted 10 lines
src/aio-dio-regress/aiodio_sparse2.c new file +7
-0@@ -0,0 +1,384 @@ +/* gcc -g -Wall -O2 aiodio_sparse.c -o aiodio_sparse -laio */ + +/* +* From http://developer.osdl.org/daniel/AIO/TESTS/aiodio_sparse.c +* With patch from https://bugzilla.redhat.com/attachment.cgi?id=142124 +* (Bug https://bugzilla.redhat.com/show_bug.cgi?id=217098) +*/
Did we manage to get a proper copyright / license statement for this one.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 9 lines · Christoph Hellwig
Quoted 6 lines · Eric Sandeen
Not entirely sure how I managed this, but 198 was not in groups so was never run - and wasn't in the makefile, so was never built. Oops.
Fix that up, make it a generic test, and move it to the aio-dio-regress subdir.
Hah, great one.
yeah, I rock! :/
Quoted 5 lines
Review
Quoted 3 lines
# This should actually run on anything that supports
O_DIRECT+ AIO...(quoted diff) +1
-1-_supported_fs xfs +_supported_fs genericmaybe also remove that comment now that it's generic.
Ok, sure.
Quoted 5 lines
Quoted 5 lines
src/aio-dio-regress/aiodio_sparse2.c new file +2
-0@@ -0,0 +1,384 @@ +/* gcc -g -Wall -O2 aiodio_sparse.c -o aiodio_sparse -laio */ +
Quoted 8 lines
src/aio-dio-regress/aiodio_sparse2.c line 7
Quoted 5 lines
src/aio-dio-regress/aiodio_sparse2.c new file +5
-0+/* +* From http://developer.osdl.org/daniel/AIO/TESTS/aiodio_sparse.c +* With patch from https://bugzilla.redhat.com/attachment.cgi?id=142124 +* (Bug https://bugzilla.redhat.com/show_bug.cgi?id=217098) +*/ Did we manage to get a proper copyright / license statement for this one.
hadn't looked into it; I'll ping Daniel McNeil who seems to be the original author ...?
But I'll fix it and worry about the copyright later, since it's already in ...
-Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 1 line · Eric Sandeen
Christoph Hellwig wrote:
...
Quoted 11 lines
Quoted 2 lines
Did we manage to get a proper copyright / license statement for this one.
hadn't looked into it; I'll ping Daniel McNeil who seems to be the original author ...?
But I'll fix it and worry about the copyright later, since it's already in ...
-Eric
Actually there's a whole whack of nice tests at
http://devresources.linux-foundation.org/daniel/AIO/TESTS/
But I'm having trouble finding Daniel ...
Seems like they'd all be good to pull in; one test per test, I guess.
-Eric
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs