newport_con: Read outside array bounds
Subsystems (2)
PATCH 1/1 newport_con: Read outside array bounds
It read linetable[] before checking bounds of index, and ARRAY_SIZE is required because linetable[] are unsigned shorts.
Signed-off-by Roel Kluin <[email protected]>
---
This one wasn't spotted by parfait.
drivers/video/console/newport_con.c +1 -1
@@ -216,7 +216,7 @@ static void newport_get_screensize(void) } newport_xsize = newport_ysize =0 ; -for (i =0 ; linetable[i +1 ] && (i <sizeof (linetable)); i +=2 ) { +for (i =0 ; i <ARRAY_SIZE (linetable) -1 && linetable[i +1 ]; i +=2 ) { cols =0 ;newport_vc2_set (npregs,VC2_IREG_RADDR , linetable[i]); npregs->set.dcbmode = (NPORT_DMODE_AVC2 | VC2_REGADDR_RAM |