io context: fix ref counting
PATCH 1/1 io context: fix ref counting
Commit d9c7d394a8ebacb60097b192939ae9f15235225e
("block: prevent possible io_context->refcount overflow") mistakenly changed atomic_inc(&ioc->nr_tasks) to atomic_long_inc(&ioc->refcount).
--- include/linux/iocontext.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/iocontext.h +1 -1
@@ -92,7 +92,7 @@ static inline struct io_context *ioc_task_link(struct io_context *ioc)* a race). */ if (ioc &&atomic_long_inc_not_zero (&ioc->refcount)) { -atomic_long_inc (&ioc->refcount); +atomic_inc (&ioc->nr_tasks);return ioc; }
Signature · 1 line
1.6.3
Quoted 4 lines · On Friday 31 July 2009 10:58:24 Li Zefan wrote:
Commit
d9c7d394a8ebacb60097b192939ae9f15235225e
("block: prevent possibleio_context->refcountoverflow") mistakenly changedatomic_inc(&ioc->nr_tasks)toatomic_long_inc(&ioc->refcount).
Ah! Sorry. :(
Quoted 1 line
Signed-off-by Li Zefan <[email protected]>
Thanks
Nikanth
Quoted 14 lines · Li Zefan
Commit
d9c7d394a8ebacb60097b192939ae9f15235225e
("block: prevent possibleio_context->refcountoverflow") mistakenly changedatomic_inc(&ioc->nr_tasks)toatomic_long_inc(&ioc->refcount).Signed-off-by Li Zefan <[email protected]>--- include/linux/iocontext.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)include/linux/iocontext.h +0
-0
include/linux/iocontext.h static inline struct io_context *ioc_task_link(struct io_context *ioc) · line 97
Quoted 7 lines
include/linux/iocontext.h +1
-1@@ -92,7 +92,7 @@ static inline struct io_context *ioc_task_link(struct io_context *ioc)* a race). */ if (ioc &&atomic_long_inc_not_zero (&ioc->refcount)) { -atomic_long_inc (&ioc->refcount); +atomic_inc (&ioc->nr_tasks);return ioc; }
Irk, good catch. Applied to immediate upstream branch.
Signature · 1 line
Jens Axboe