wpa_test not used in wpa.c
It seems to me that in this method (and others), wpa_test is not actually assigned a useful value, but it's still tested in code branches.
ieee80211_txrx_result ieee80211_rx_h_michael_mic_verify(struct ieee80211_txrx_data *rx)
In this one, it seems to always force a code branch to happen:
ieee80211_txrx_result ieee80211_tx_h_michael_mic_add(struct ieee80211_txrx_data *tx)
Any idea on how this is supposed to work?
Thanks,
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 6 lines · Ben Greear
It seems to me that in this method (and others),
wpa_testis not actually assigned a useful value, but it's still tested in code branches.Any idea on how this is supposed to work?
It isn't really. It's some dead code that you can enable manually for testing or so. It used to be possible to use a private ioctl or so to set it, iirc, but that's long gone. I'd have no objections to just removing it.
johannes
Quoted 6 lines · Johannes Berg
Quoted 5 lines · Ben Greear
It seems to me that in this method (and others),
wpa_testis not actually assigned a useful value, but it's still tested in code branches.
Quoted 9 lines
Quoted 1 line
Any idea on how this is supposed to work?
It isn't really. It's some dead code that you can enable manually for testing or so. It used to be possible to use a private ioctl or so to set it, iirc, but that's long gone. I'd have no objections to just removing it.
johannes
Also, it doesn't look like this is getting compiled in any build - AFAIK "txrx" classes are long gone (since 2.6.26 or so)...
Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)