ALSA: Read buffer overflow
PATCH 1/1 ALSA: Read buffer overflow
Check whether index is within bounds before testing the element.
Signed-off-by Roel Kluin <[email protected]>
---
sound/pci/hda/patch_realtek.c +1 -1
@@ -559,7 +559,7 @@ static int alc_pin_mode_get(struct snd_kcontrol *kcontrol,/* Find enumerated value for current pinctl setting */ i =alc_pin_mode_min (dir); -while (alc_pin_mode_values[i] != pinctl && i <=alc_pin_mode_max (dir)) +while (i <=alc_pin_mode_max (dir) && alc_pin_mode_values[i] != pinctl) i++; *valp = i <=alc_pin_mode_max (dir) ? i:alc_pin_mode_min (dir);return 0 ;
At Sun, 02 Aug 2009 13:30:45 +0200,
Quoted 4 lines · Roel Kluin
Check whether index is within bounds before testing the element.
Signed-off-by Roel Kluin <[email protected]>
Applied now. Thanks.
Takashi
Quoted 15 lines
---
sound/pci/hda/patch_realtek.c +1
-1@@ -559,7 +559,7 @@ static int alc_pin_mode_get(struct snd_kcontrol *kcontrol,/* Find enumerated value for current pinctl setting */ i =alc_pin_mode_min (dir); -while (alc_pin_mode_values[i] != pinctl && i <=alc_pin_mode_max (dir)) +while (i <=alc_pin_mode_max (dir) && alc_pin_mode_values[i] != pinctl) i++; *valp = i <=alc_pin_mode_max (dir) ? i:alc_pin_mode_min (dir);return 0 ;