Skip to contentSkip to conversation

ssb: Fix e typo in the rev8 SPROM extraction routine

PATCH In review Gábor Stefanik 2 participants 3 messages Aug 14, 2009 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: Fix e typo in the rev8 SPROM extraction routine

No comment. :-)

---
Mark, this should fix your MAC address bug. Anyone else testing LP-PHY should also apply this.

drivers/ssb/pci.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ssb/pci.c +0 -0
index 50811e4..335a43f 100644
@@ -480,7 +480,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
 
	/* extract the MAC address */
	for (i = 0; i < 3; i++) {
-		v = in[SPOFF(SSB_SPROM1_IL0MAC) + i];
+		v = in[SPOFF(SSB_SPROM8_IL0MAC) + i];
		*(((__be16 *)out->il0mac) + i) = cpu_to_be16(v);
	}
	SPEX(country_code, SSB_SPROM8_CCODE, 0xFFFF, 0);
Signature · 1 line
1.6.2.4
#1 lore raw

John, please fix the typo in the commit name... how ironic this is a typo fix patch. :-)

2009/8/14 Gábor Stefanik <[email protected]>:

Quoted 30 lines

No comment. :-)

---
Mark, this should fix your MAC address bug. Anyone else testing LP-PHY should also apply this.

drivers/ssb/pci.c |    2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ssb/pci.c +1 -1
index 50811e4..335a43f 100644
@@ -480,7 +480,7 @@ static void sprom_extract_r8(struct ssb_sprom *out,
 const u16 *in)
 
        /* extract the MAC address */
        for (i = 0; i < 3; i++) {
-               v = in[SPOFF(SSB_SPROM1_IL0MAC) + i];
+               v = in[SPOFF(SSB_SPROM8_IL0MAC) + i];
                *(((__be16 *)out->il0mac) + i) = cpu_to_be16(v);
        }

       SPEX(country_code, SSB_SPROM8_CCODE, 0xFFFF, 0); --
1.6.2.4

Signature · 1 line
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
#2 lore raw
In reply to Gábor Stefanik
Quoted 15 lines · On Friday 14 August 2009 14:11:53 Gábor Stefanik wrote:

No comment. :-)

---
Mark, this should fix your MAC address bug. Anyone else testing LP-PHY should also apply this.

 drivers/ssb/pci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ssb/pci.c +0 -0
index 50811e4..335a43f 100644

drivers/ssb/pci.c static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in) · line 486

Quoted 8 lines
drivers/ssb/pci.c +1 -1
@@ -480,7 +480,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
 
 	/* extract the MAC address */
 	for (i = 0; i < 3; i++) {
-		v = in[SPOFF(SSB_SPROM1_IL0MAC) + i];
+		v = in[SPOFF(SSB_SPROM8_IL0MAC) + i];
 		*(((__be16 *)out->il0mac) + i) = cpu_to_be16(v);
 	}
 	SPEX(country_code, SSB_SPROM8_CCODE, 0xFFFF, 0);

ack

Signature · 1 line
Greetings, Michael.