Skip to contentSkip to conversation

gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one()

PATCH In review Roel Kluin 2 participants 2 messages Aug 22, 2009 – Aug 24, 2009 SCSI

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 gdth: unmap ccb_phys when scsi_add_host() fails in gdth_eisa_probe_one()

unmap ccb_phys as well when scsi_add_host() fails

Signed-off-by Roel Kluin <[email protected]>

---
Right?

drivers/scsi/gdth.c +1 -1
index 185e6bc..3111503 100644
@@ -4903,7 +4903,7 @@ static int __init gdth_eisa_probe_one(ushort eisa_slot)
 
 	error = scsi_add_host(shp, NULL);
 	if (error)
-		goto out_free_coal_stat;
+		goto out_free_ccb_phys;
 	list_add_tail(&ha->list, &gdth_instances);
 	gdth_timer_init();
#1 lore raw
Quoted 5 lines · On Sat, 22 Aug 2009 19:05:52 +0200 Roel Kluin <[email protected]> wrote:

unmap ccb_phys as well when scsi_add_host() fails

Signed-off-by Roel Kluin <[email protected]>

---
Right?

Partially.

drivers/scsi/gdth.c static int __init gdth_eisa_probe_one(ushort eisa_slot) · line 4909

Quoted 13 lines
drivers/scsi/gdth.c +1 -1
index 185e6bc..3111503 100644
@@ -4903,7 +4903,7 @@ static int __init gdth_eisa_probe_one(ushort eisa_slot)
 
 	error = scsi_add_host(shp, NULL);
 	if (error)
-		goto out_free_coal_stat;
+		goto out_free_ccb_phys;
 	list_add_tail(&ha->list, &gdth_instances);
 	gdth_timer_init();

I suspect that we should also undo the effects of gdth_enable_int() if taking this path.