vsprintf: use WARN_ON_ONCE
Subsystems (2)
PATCH RESEND 1/1 vsprintf: use WARN_ON_ONCE
From: Marcin Slusarz <[email protected]>
Subject: vsprintf: use WARN_ON_ONCE
Signed-off-by Marcin Slusarz <[email protected]>
lib/vsprintf.c +2 -12
@@ -983,13 +983,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)/* Reject out-of-range values early. Large positive sizes are used for unknown buffer sizes. */ -if (unlikely ((int ) size <0 )) { -/* There can be only one.. */ -static char warn =1 ; -WARN_ON (warn); - warn =0 ; +if (WARN_ON_ONCE ((int ) size <0 ))return 0 ; - } str = buf; end = buf + size;
@@ -1439,13 +1434,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)struct printf_spec spec = {0 }; -if (unlikely ((int ) size <0 )) { -/* There can be only one.. */ -static char warn =1 ; -WARN_ON (warn); - warn =0 ; +if (WARN_ON_ONCE ((int ) size <0 ))return 0 ; - } str = buf; end = buf + size;
Quoted 4 lines · Marcin Slusarz
From: Marcin Slusarz <[email protected]>
Subject: vsprintf: useWARN_ON_ONCESigned-off-by Marcin Slusarz <[email protected]>
Reviewed-by Frederic Weisbecker <[email protected]>
Quoted 35 lines
lib/vsprintf.c +2
-12@@ -983,13 +983,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)/* Reject out-of-range values early. Large positive sizes are used for unknown buffer sizes. */ -if (unlikely ((int ) size <0 )) { -/* There can be only one.. */ -static char warn =1 ; -WARN_ON (warn); - warn =0 ; +if (WARN_ON_ONCE ((int ) size <0 ))return 0 ; - } str = buf; end = buf + size;@@ -1439,13 +1434,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)struct printf_spec spec = {0 }; -if (unlikely ((int ) size <0 )) { -/* There can be only one.. */ -static char warn =1 ; -WARN_ON (warn); - warn =0 ; +if (WARN_ON_ONCE ((int ) size <0 ))return 0 ; - } str = buf; end = buf + size;