cio: double put_device() in subchannel_register()
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Quoted 3 lines · Roel Kluin
If the device can't be registered,
put_device(&cdev->dev)occured here and afterout_err:.
The additional put_device should not be removed.
To register a ccw device we use device_initialize, do some asynchronous recognition and call io_subchannel_register() via a workqueue.
So in io_subchannel_register the refcount should be 2 (1 for the initialization and 1 for workqueue processing). If the device_add fails at this point we drop both references, so that the devices' release function gets called.
Regards,
Sebastian
Quoted 20 lines
Signed-off-by Roel Kluin <[email protected]>---
drivers/s390/cio/device.c +0
-3@@ -999,8 +999,6 @@ io_subchannel_register(struct work_struct *work)spin_lock_irqsave (sch->lock, flags);sch_set_cdev (sch,NULL );spin_unlock_irqrestore (sch->lock, flags); -/* Release initial device reference. */ -put_device (&cdev->dev); goto out_err; } out: --To unsubscribe from this list: send the line "unsubscribe linux-s390" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html