Skip to contentSkip to conversation

tracing: block-able ring_buffer consumer

PATCH In review Lai Jiangshan 2 participants 3 messages Aug 27, 2009 – Aug 29, 2009

lore
Share & tools
lore
#0 lore raw

cover tracing: block-able ring_buffer consumer

The first patch fixes a bug of splice_read for ring_buffer, and makes rb_get_reader_page() can be easily used by block-able/poll-able codes.

The other patches make consumer block-able and poll-able.

---
 b/include/linux/ftrace.h      |    6 ++
 b/include/linux/ring_buffer.h |    4 +
 b/kernel/timer.c              |    2
 b/kernel/trace/ring_buffer.c  |   29 +++++++------
 b/kernel/trace/trace.c        |   39 ++++++++++++++++--
 include/linux/ring_buffer.h   |    3 +
 kernel/trace/ring_buffer.c    |   89 ++++++++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.c          |    9 ++++
 8 files changed, 163 insertions(+), 18 deletions(-)
#1 lore raw
Quoted 5 lines · Lai Jiangshan

The first patch fixes a bug of splice_read for ring_buffer, and makes rb_get_reader_page() can be easily used by block-able/poll-able codes.

The other patches make consumer block-able and poll-able.

Hi Lai,

Thanks, I'll take a look at these patches tomorrow.

-- Steve

Quoted 17 lines
---
 b/include/linux/ftrace.h      |    6 ++
 b/include/linux/ring_buffer.h |    4 +
 b/kernel/timer.c              |    2
 b/kernel/trace/ring_buffer.c  |   29 +++++++------
 b/kernel/trace/trace.c        |   39 ++++++++++++++++--
 include/linux/ring_buffer.h   |    3 +
 kernel/trace/ring_buffer.c    |   89 ++++++++++++++++++++++++++++++++++++++++++
 kernel/trace/trace.c          |    9 ++++
 8 files changed, 163 insertions(+), 18 deletions(-)
#2 lore raw
Quoted 5 lines · Steven Rostedt
Quoted 3 lines · Lai Jiangshan

The first patch fixes a bug of splice_read for ring_buffer, and makes rb_get_reader_page() can be easily used by block-able/poll-able codes.

Quoted 8 lines
Quoted 1 line

The other patches make consumer block-able and poll-able.

Hi Lai,

Thanks, I'll take a look at these patches tomorrow.

-- Steve

Hi, Steven

Thanks, could you give some comments?

Regards,

Lai