Skip to contentSkip to conversation

au1000_eth: possible NULL dereference of aup->mii_bus->irq in au1000_probe()

PATCH Applied Roel Kluin 3 participants 3 messages Aug 31, 2009 – Sep 2, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 au1000_eth: possible NULL dereference of aup->mii_bus->irq in au1000_probe()

aup->mii_bus->irq allocation may fail, prevent a dereference of NULL.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/au1000_eth.c +3 -0
index d3c734f..02e4be0 100644
@@ -1157,6 +1157,9 @@ static struct net_device * au1000_probe(int port_num)
 	aup->mii_bus->name = "au1000_eth_mii";
 	snprintf(aup->mii_bus->id, MII_BUS_ID_SIZE, "%x", aup->mac_id);
 	aup->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
+	if (aup->mii_bus->irq == NULL)
+		goto err_out;
+
 	for(i = 0; i < PHY_MAX_ADDR; ++i)
 		aup->mii_bus->irq[i] = PHY_POLL;
Acked-by on v1 1/1
#1 lore raw

Hello Roel,

Quoted 1 line · Roel Kluin

aup->mii_bus->irq allocation may fail, prevent a dereference of NULL.

Good catch.

Quoted 2 lines
Signed-off-by Roel Kluin <[email protected]>
Acked-by Florian Fainelli <[email protected]>
Quoted 19 lines

---

drivers/net/au1000_eth.c +3 -1
index d3c734f..02e4be0 100644
@@ -1157,6 +1157,9 @@ static struct net_device * au1000_probe(int port_num)
 	aup->mii_bus->name = "au1000_eth_mii";
 	snprintf(aup->mii_bus->id, MII_BUS_ID_SIZE, "%x", aup->mac_id);
 	aup->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
+	if (aup->mii_bus->irq == NULL)
+		goto err_out;
+
 	for(i = 0; i < PHY_MAX_ADDR; ++i)
 		aup->mii_bus->irq[i] = PHY_POLL;
 
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Cordialement, Florian Fainelli
------------------------------