Skip to contentSkip to conversation

Change clean rules to properly remove files

PATCH In review Yves Blusseau 3 participants 6 messages Sep 2, 2009 – Sep 12, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Change clean rules to properly remove files

ChangeLog:

2009-09-02 Yves Blusseau <[email protected]>

Change clean rules to properly remove files

* genmk.rb: add new clean rules
* Makefile.in (clean): add the new targets
(mostlyclean): likewise
---
Makefile.in | 4 ++--
genmk.rb | 55 +++++++++++++++++++++++++++++++++++++++++++++++--------

2 files changed, 49 insertions(+), 10 deletions(-)
Makefile.in +2 -2
index 8e2cdc6..3af1266 100644
@@ -325,10 +325,10 @@ uninstall:
 	  rm -f $(DESTDIR)$(libdir)/grub/$$dest; \
 	done
 
-clean:
+clean: $(CLEAN_IMAGE_TARGETS) $(CLEAN_MODULE_TARGETS) $(CLEAN_UTILITY_TARGETS)
 	-test -z "$(CLEANFILES)" || rm -f $(CLEANFILES)
 
-mostlyclean: clean
+mostlyclean: clean $(MOSTLYCLEAN_IMAGE_TARGETS) $(MOSTLYCLEAN_MODULE_TARGETS) $(MOSTLYCLEAN_UTILITY_TARGETS)
 	-test -z "$(MOSTLYCLEANFILES)" || rm -f $(MOSTLYCLEANFILES)
 
 distclean: mostlyclean
genmk.rb +47 -8

122 lines not on this page · raw message

#1 lore raw
Quoted 6 lines · Yves Blusseau

ChangeLog:

2009-09-02 Yves Blusseau <[email protected]>

Change clean rules to properly remove files

Quoted 8 lines

* genmk.rb: add new clean rules
* Makefile.in (clean): add the new targets
(mostlyclean): likewise
---
Makefile.in | 4 ++--
genmk.rb | 55 ++++++++++++++++++++++++++++++++++++++++++++++
+--------

2 files changed, 49 insertions(+), 10 deletions(-)

Is it ok to commit ?

Regards,
Yves Blusseau

#2 lore raw
Quoted 2 lines · Yves Blusseau

Is it ok to commit ?

Please wait a few more days. It's doubtful that anyone would be interested (and capable) of reviewing ruby code, but it's still worth a try.

If noone objects, you can commit this.

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 8 lines · Robert Millan
Quoted 1 line · Yves Blusseau

Is it ok to commit ?

Please wait a few more days. It's doubtful that anyone would be interested (and capable) of reviewing ruby code, but it's still worth a try.

If noone objects, you can commit this.

I don't know if someone encountered the same issue yet, but, when doing
a 'make clean', 'rm' returned the error that it can't handle too much files at a time.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqj0sYACgkQBV7eXqefhqg0swCghrwbEK6GDqFsTGnfIZCPYr7m IREAnR+jYg0mQDJ/wtJkBlnCOU1gVBTI
=Ibj+
-----END PGP SIGNATURE-----

#4 lore raw
Quoted 10 lines · Duboucher Thomas

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Robert Millan
Quoted 1 line · Yves Blusseau

Is it ok to commit ?

Please wait a few more days. It's doubtful that anyone would be interested (and capable) of reviewing ruby code, but it's still worth a try.

Quoted 7 lines
Quoted 2 lines

If noone objects, you can commit this.

I don't know if someone encountered the same issue yet, but, when
doing
a 'make clean', 'rm' returned the error that it can't handle too much files at a time.

This it what the patch fix.

Regards,
Yves Blusseau

#5 lore raw
In reply to Robert Millan
Quoted 8 lines · Robert Millan
Quoted 2 lines · Yves Blusseau

Is it ok to commit ?

Please wait a few more days. It's doubtful that anyone would be interested (and capable) of reviewing ruby code, but it's still worth a try.

If noone objects, you can commit this.

Commited.