Skip to contentSkip to conversation

s5pc1xx: add support SMDKC100 board

PATCH Superseded Minkyu Kang 6 participants 15 messages Sep 10, 2009 – Oct 9, 2009

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 4/4 s5pc1xx: add support SMDKC100 board

Add new board SMDKC100 that uses s5pc100 SoC

---
 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   54 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  221 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  198 +++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   78 ++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 include/configs/smdkc100.h             |  247 ++++++++++++++++++++++++++++++++
 10 files changed, 873 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 include/configs/smdkc100.h
MAINTAINERS +4 -0
index 439c1b8..eddf736 100644
@@ -725,6 +725,10 @@ Alex Z
 	lart		SA1100
 	dnp1110		SA1110
 
+Minkyu Kang <[email protected]>
+
+	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:
MAKEALL +1 -0
index 13f3f5e..0b779dc 100755
@@ -588,6 +588,7 @@ LIST_ARM_CORTEX_A8="		\
 	omap3_pandora		\
 	omap3_zoom1		\
 	omap3_zoom2		\
+	smdkc100		\
 "
 
 #########################################################################
Makefile +3 -0
index df22bff..8f69c17 100644
@@ -3169,6 +3169,9 @@ omap3_zoom1_config :	unconfig
 omap3_zoom2_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
 
+smdkc100_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx
+
 #########################################################################
 ## XScale Systems
 #########################################################################
board/samsung/smdkc100/Makefile new file +54 -0

54 lines not on this page · raw message

board/samsung/smdkc100/config.mk new file +16 -0
new file mode 100644
index 0000000..ebab420
@@ -0,0 +1,16 @@
+#
+# Copyright (C) 2008 # Samsung Elecgtronics
+# Kyungmin Park <[email protected]>
+#
+
+# On S5PC100 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x38000000 to 0x40000000 (128MiB)
+#
+# On S5PC110 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x40000000 to 0x48000000 (128MiB)
+#
+TEXT_BASE = 0x34800000
board/samsung/smdkc100/lowlevel_init.S new file +221 -0

221 lines not on this page · raw message

board/samsung/smdkc100/mem_setup.S new file +198 -0

198 lines not on this page · raw message

board/samsung/smdkc100/onenand.c new file +78 -0

78 lines not on this page · raw message

board/samsung/smdkc100/smdkc100.c new file +51 -0

51 lines not on this page · raw message

include/configs/smdkc100.h new file +247 -0

247 lines not on this page · raw message

Signature · 1 line
1.5.4.3
#1 lore raw

PATCH v2 4/4 s5pc1xx: add support SMDKC100 board

Dear Minkyu Kang,

Quoted 4 lines · In message <[email protected]> you wrote:

Add new board SMDKC100 that uses s5pc100 SoC

...

include/configs/smdkc100.h line 30

Quoted 3 lines
include/configs/smdkc100.h new file +3 -0
+#ifndef __CONFIG_H
+#define __CONFIG_H
+#include <asm/sizes.h>

Please don't use this header; it will probably be removed soon.

...

include/configs/smdkc100.h line 49

Quoted 4 lines
include/configs/smdkc100.h new file +4 -0
+/*
+ * Architecture magic and machine type
+ */
+#define MACH_TYPE_SMDKC100	1826

Please don't. Only use the constants defined in mach-types.h

...

include/configs/smdkc100.h line 240

Quoted 7 lines
include/configs/smdkc100.h new file +7 -0
+/*-----------------------------------------------------------------------
+ * Boot configuration (define only one of next 3)
+ */
+#define CONFIG_ENV_IS_IN_ONENAND	1
+#define CONFIG_ENV_SIZE			SZ_128K		/* 128KB, 0x20000 */
+#define CONFIG_ENV_ADDR			SZ_256K		/* 256KB, 0x40000 */
+#define CONFIG_ENV_OFFSET		SZ_256K		/* 256KB, 0x40000 */

What does the "define only one of next 3" part mean?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Though a program be but three lines long,
someday it will have to be maintained."
- The Tao of Programming
#2 lore raw

PATCH v2 4/4 s5pc1xx: add support SMDKC100 board

Dear Wolfgang

2009/9/10 Wolfgang Denk <[email protected]>:

Quoted 5 lines

Dear Minkyu Kang,

Quoted 2 lines · In message <[email protected]> you wrote:

Add new board SMDKC100 that uses s5pc100 SoC

Quoted 9 lines
Quoted 2 lines

...

include/configs/smdkc100.h line 30

Quoted 3 lines
include/configs/smdkc100.h new file +3 -0
+#ifndef __CONFIG_H
+#define __CONFIG_H
+#include <asm/sizes.h>

Please don't use this header; it will probably be removed soon.

ok, I'll also remove SZ_XX defines

Quoted 8 lines

...

include/configs/smdkc100.h

Quoted 4 lines
include/configs/smdkc100.h new file +4 -0
+/*
+ * Architecture magic and machine type
+ */
+#define MACH_TYPE_SMDKC100 ? 1826

Please don't. Only use the constants defined in mach-types.h

it will be deleted

Quoted 11 lines

...

Review

Quoted 7 lines
(quoted diff) +7 -0
+/*-----------------------------------------------------------------------
+ * Boot configuration (define only one of next 3)
+ */
+#define CONFIG_ENV_IS_IN_ONENAND ? ? 1
+#define CONFIG_ENV_SIZE ? ? ? ? ? ? ? ? ? ? ?SZ_128K ? ? ? ? /* 128KB, 0x20000 */
+#define CONFIG_ENV_ADDR ? ? ? ? ? ? ? ? ? ? ?SZ_256K ? ? ? ? /* 256KB, 0x40000 */
+#define CONFIG_ENV_OFFSET ? ? ? ? ? ?SZ_256K ? ? ? ? /* 256KB, 0x40000 */

What does the "define only one of next 3" part mean?

ah.. SMDKC100 can boot by onenand, nand and flash. that means.. must define one of three.. anyway it will be deleted.

Quoted 5 lines

Best regards,

Wolfgang Denk

Quoted 12 lines

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Though a program be but three lines long,
someday it will have to be maintained."
- The Tao of Programming
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

thanks

Signature · 2 lines
from. prom.
www.promsoft.net
#3 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
 10 files changed, 867 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 include/configs/smdkc100.h
MAINTAINERS +4 -0
index 439c1b8..eddf736 100644
@@ -725,6 +725,10 @@ Alex Z
 	lart		SA1100
 	dnp1110		SA1110
 
+Minkyu Kang <[email protected]>
+
+	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:
MAKEALL +1 -0
index 13f3f5e..0b779dc 100755
@@ -588,6 +588,7 @@ LIST_ARM_CORTEX_A8="		\
 	omap3_pandora		\
 	omap3_zoom1		\
 	omap3_zoom2		\
+	smdkc100		\
 "
 
 #########################################################################
Makefile +3 -0
index df22bff..8f69c17 100644
@@ -3169,6 +3169,9 @@ omap3_zoom1_config :	unconfig
 omap3_zoom2_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
 
+smdkc100_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx
+
 #########################################################################
 ## XScale Systems
 #########################################################################
board/samsung/smdkc100/Makefile new file +55 -0

55 lines not on this page · raw message

board/samsung/smdkc100/config.mk new file +16 -0
new file mode 100644
index 0000000..ebab420
@@ -0,0 +1,16 @@
+#
+# Copyright (C) 2008 # Samsung Elecgtronics
+# Kyungmin Park <[email protected]>
+#
+
+# On S5PC100 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x38000000 to 0x40000000 (128MiB)
+#
+# On S5PC110 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x40000000 to 0x48000000 (128MiB)
+#
+TEXT_BASE = 0x34800000
board/samsung/smdkc100/lowlevel_init.S new file +215 -0

215 lines not on this page · raw message

board/samsung/smdkc100/mem_setup.S new file +197 -0

197 lines not on this page · raw message

board/samsung/smdkc100/onenand.c new file +83 -0

83 lines not on this page · raw message

board/samsung/smdkc100/smdkc100.c new file +51 -0

51 lines not on this page · raw message

include/configs/smdkc100.h new file +242 -0

242 lines not on this page · raw message

Signature · 1 line
1.5.4.3
#4 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 27 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
Quoted 9 lines
 10 files changed, 867 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 include/configs/smdkc100.h

Please include a brief readme doc/README.s5pc1xx similar to README.omap

<snip>

board/samsung/smdkc100/lowlevel_init.S line 58

Quoted 7 lines
board/samsung/smdkc100/lowlevel_init.S new file +7 -0
+
+#ifndef CONFIG_ONENAND_IPL
+	/* setting SRAM */
+	ldr	r0, =S5PC100_SROMC_BASE
+	ldr	r1, =0x9
+	str	r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Tom

#5 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 38 lines · Tom
Quoted 27 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
Quoted 9 lines
 10 files changed, 867 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 include/configs/smdkc100.h
Quoted 1 line

Please include a brief readme doc/README.s5pc1xx similar to README.omap

Hi Tom,
Others may disagree, but I'm personally opposed to creating board/vendor-specific doc/README.<board> files in most cases. My logic is that the people that are compiling and using U-Boot on my company's boards will have bought the boards from us, and we should be the ones providing them documentation. eg I would guess the vast majority of board vendors don't say "for board information consult doc/README.<board> in the U-Boot source code", they provide a PDF, text document, datasheet, etc about the board and how it can be used. Thus the doc/README.<board> doesn't really provide any useful info.

I think the doc/README.<board> files have a tendency to get out of date, reference old commands, etc so are often not the best source of reference anyway. eg take a look at doc/README.m5373evb. I'd argue a lot of that info isn't necessary, and some of its duplicated in other places.

I only care because I hate having to pick through 10 board-specific README files every time I make a change the renames a command, adds a new command, changes a CONFIG_XYZ name, etc:)

I think README files are good in general, but board-specific details should be documented elsewhere such as a product manual.

Anyway, that's my $.02.

Best,
Peter

#6 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 38 lines · Peter Tyser
Quoted 37 lines · Tom
Quoted 36 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
 10 files changed, 867 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 include/configs/smdkc100.h
Quoted 4 lines
Quoted 1 line

Please include a brief readme doc/README.s5pc1xx similar to README.omap

Hi Tom,
Others may disagree, but I'm personally opposed to creating

Slugfest over documentation!

I can see you point. If you have the board you likely have the user manual. In no way do I want a user manual.

Mostly what I am looking for brief product description and a list of the configs. Maybe some hints if the setup is tricky. README.omap3 contains writeups on 6 boards, each get about 10 lines.

The vendor readme is also good if you want to convey board family u-boot interfaces to other developers. See my writeup of omap gpio in omap3.

Quoted 8 lines

board/vendor-specific doc/README.<board> files in most cases. My logic is that the people that are compiling and using U-Boot on my company's boards will have bought the boards from us, and we should be the ones providing them documentation. eg I would guess the vast majority of board vendors don't say "for board information consult doc/README.<board> in the U-Boot source code", they provide a PDF, text document, datasheet, etc about the board and how it can be used. Thus the doc/README.<board> doesn't really provide any useful info.

This is doc/README.<soc>

Quoted 7 lines

I think the doc/README.<board> files have a tendency to get out of date, reference old commands, etc so are often not the best source of reference anyway. eg take a look at doc/README.m5373evb. I'd argue a lot of that info isn't necessary, and some of its duplicated in other places.

Yes this is excessive :|

Quoted 4 lines

I only care because I hate having to pick through 10 board-specific README files every time I make a change the renames a command, adds a new command, changes a CONFIG_XYZ name, etc:)

This should be the task of the board/soc maintainer.

Quoted 4 lines

I think README files are good in general, but board-specific details should be documented elsewhere such as a product manual.

Anyway, that's my $.02.

Taking it outside over documentation,
Tom

Quoted 4 lines

Best,
Peter

#7 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Quoted 1 line

Please include a brief readme doc/README.s5pc1xx similar to README.omap

Hi Tom,
Others may disagree, but I'm personally opposed to creating

Slugfest over documentation!

Nothing gets me more worked up than a documentation discussion:)

Quoted 6 lines

I can see you point. If you have the board you likely have the user manual. In no way do I want a user manual.

Mostly what I am looking for brief product description and a list of the configs. Maybe some hints if the setup is tricky. README.omap3 contains writeups on 6 boards, each get about 10 lines.

The README.omap3 looks decent, but even that I would personally have a few issues with the following:
1. The list of omap3 boards is going to get out of date quickly when people don't update README.omap3. Eg devkit8000 already isn't in the list:)

2. I still think the details of how to configure U-Boot for a board, use the ecc commands, and gpio interfaces would still be better placed in a User's Manual. New users will use the User's Manual and experienced users will know how to dig through the code - eg I'm not sure who will reference README.omap3:). Those command names and config names will probably change at some point in the future, and there's a decent chance README.omap3 won't be similarly updated.

Quoted 2 lines

The vendor readme is also good if you want to convey board family u-boot interfaces to other developers. See my writeup of omap gpio in omap3.

I see your point. If it were me, I'd throw that documentation in the omap3 gpio driver itself. Its much more likely to be kept in sync when code changes, and if someone is writing low-level U-Boot code, I'd hope they'd be smart enough to track down the gpio driver they need to use.

Quoted 10 lines
Quoted 8 lines

board/vendor-specific doc/README.<board> files in most cases. My logic is that the people that are compiling and using U-Boot on my company's boards will have bought the boards from us, and we should be the ones providing them documentation. eg I would guess the vast majority of board vendors don't say "for board information consult doc/README.<board> in the U-Boot source code", they provide a PDF, text document, datasheet, etc about the board and how it can be used. Thus the doc/README.<board> doesn't really provide any useful info.

This is doc/README.<soc>

OK, I missed that point. SOC documentation does seem more fitting. I personally think low-level details shouldn't be in the SOC doc however. For example, take a look at README.blackfin. There's nothing I could ever change about U-Boot which would require this file to be updated, which is perfect!

<snip>

Quoted 6 lines
Quoted 4 lines

I only care because I hate having to pick through 10 board-specific README files every time I make a change the renames a command, adds a new command, changes a CONFIG_XYZ name, etc:)

This should be the task of the board/soc maintainer.

I think this is debatable. I'd guess most board maintainers don't follow the list closely or care enough to monitor every change and determine if they need to update their board's README file. So if the person making a large change doesn't update relevant READMEs, no one will. Eg, no one added devkit8000 to README.omap3.

Quoted 6 lines
Quoted 4 lines

I think README files are good in general, but board-specific details should be documented elsewhere such as a product manual.

Anyway, that's my $.02.

Taking it outside over documentation,

Best,
Peter

#8 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

In reply to Tom

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 38 lines
Quoted 27 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

?MAINTAINERS ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?4 +
?MAKEALL ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?| ? ?1 +
?Makefile ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | ? ?3 +
?board/samsung/smdkc100/Makefile ? ? ? ?| ? 55 +++++++
?board/samsung/smdkc100/config.mk ? ? ? | ? 16 ++
?board/samsung/smdkc100/lowlevel_init.S | ?215 ++++++++++++++++++++++++++++
?board/samsung/smdkc100/mem_setup.S ? ? | ?197 ++++++++++++++++++++++++++
?board/samsung/smdkc100/onenand.c ? ? ? | ? 83 +++++++++++
?board/samsung/smdkc100/smdkc100.c ? ? ?| ? 51 +++++++
?include/configs/smdkc100.h ? ? ? ? ? ? | ?242 ++++++++++++++++++++++++++++++++
Quoted 9 lines

?10 files changed, 867 insertions(+), 0 deletions(-) ?create mode 100644 board/samsung/smdkc100/Makefile ?create mode 100644 board/samsung/smdkc100/config.mk ?create mode 100644 board/samsung/smdkc100/lowlevel_init.S ?create mode 100644 board/samsung/smdkc100/mem_setup.S ?create mode 100644 board/samsung/smdkc100/onenand.c ?create mode 100644 board/samsung/smdkc100/smdkc100.c ?create mode 100644 include/configs/smdkc100.h

Quoted 1 line

Please include a brief readme doc/README.s5pc1xx similar to README.omap

ok I will.

Quoted 13 lines

<snip>

Review

Quoted 7 lines
(quoted diff) +7 -0
+
+#ifndef CONFIG_ONENAND_IPL
+ ? ? /* setting SRAM */
+ ? ? ldr ? ? r0, =S5PC100_SROMC_BASE
+ ? ? ldr ? ? r1, =0x9
+ ? ? str ? ? r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. but not yet applied onenand_ipl patch for s5pc1xx.
When that patch is applied, we need these logic.
If necessary, I'll delete these logic until apply the patch.

Quoted 7 lines

Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#9 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 9 lines · Minkyu Kang

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 6 lines
Quoted 5 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---

<snip>

Quoted 9 lines
Quoted 8 lines

board/samsung/smdkc100/lowlevel_init.S line 58

Quoted 6 lines
board/samsung/smdkc100/lowlevel_init.S new file +6 -0
+#ifndef CONFIG_ONENAND_IPL
+     /* setting SRAM */
+     ldr     r0, =S5PC100_SROMC_BASE
+     ldr     r1, =0x9
+     str     r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Quoted 5 lines

Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. but not yet applied onenand_ipl patch for s5pc1xx.
When that patch is applied, we need these logic.
If necessary, I'll delete these logic until apply the patch.

If the patch already exits, it would be better if it was in this patchset. Can we get the onenand_ipl patch ?

Tom

#10 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 32 lines
Quoted 12 lines · Minkyu Kang

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 8 lines
Quoted 6 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---

<snip>

Quoted 10 lines
Quoted 9 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+#ifndef CONFIG_ONENAND_IPL
+ ? ? /* setting SRAM */
+ ? ? ldr ? ? r0, =S5PC100_SROMC_BASE
+ ? ? ldr ? ? r1, =0x9
+ ? ? str ? ? r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Quoted 5 lines

Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. but not yet applied onenand_ipl patch for s5pc1xx.
When that patch is applied, we need these logic.
If necessary, I'll delete these logic until apply the patch.

Quoted 6 lines

If the patch already exits, it would be better if it was in this patchset. ?Can we get the onenand_ipl patch ?

Tom

please see below link
http://lists.denx.de/pipermail/u-boot/2009-August/059590.html

As you seen, that patch just prepare to add s5pc100 soc actually we need more patches for add board files into onenand_ipl and add #ifndef logic at arm_cortaxa8/start.S

so, I plan them to next patch
How you think?

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#11 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

In reply to Tom
Quoted 22 lines · Tom
Quoted 9 lines · Minkyu Kang

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 6 lines
Quoted 5 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---

<snip>

Quoted 9 lines
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+#ifndef CONFIG_ONENAND_IPL
+ ? ? /* setting SRAM */
+ ? ? ldr ? ? r0, =S5PC100_SROMC_BASE
+ ? ? ldr ? ? r1, =0x9
+ ? ? str ? ? r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Quoted 8 lines
Quoted 5 lines

Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. but not yet applied onenand_ipl patch for s5pc1xx.
When that patch is applied, we need these logic.
If necessary, I'll delete these logic until apply the patch.

If the patch already exits, it would be better if it was in this patchset. ?Can we get the onenand_ipl patch ?

To support the s5pc1xx OneNAND IPL. It needs to refactor the current OneNAND IPL.

Now I refactor the OneNAND IPL code first and then I will send a OneNAND IPL codes for s5pc1xx.

I want to leave current patch as is. Since If we delete the OneNAND IPL codes. No one can refer the codes. I mean OneNAND IPL parts contains clock and memory configuration. These are helpful to someone who use NAND or NOR.

Thank you,
Kyungmin Park

#12 lore raw

PATCH v3 4/4 s5pc1xx: add support SMDKC100 board

Quoted 32 lines · Kyungmin Park
Quoted 20 lines · Tom
Quoted 9 lines · Minkyu Kang

Dear Tom

2009/9/23 Tom <[email protected]>:

Quoted 6 lines
Quoted 5 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---

<snip>

Quoted 8 lines
Quoted 8 lines

board/samsung/smdkc100/lowlevel_init.S line 58

Quoted 6 lines
board/samsung/smdkc100/lowlevel_init.S new file +6 -0
+#ifndef CONFIG_ONENAND_IPL
+     /* setting SRAM */
+     ldr     r0, =S5PC100_SROMC_BASE
+     ldr     r1, =0x9
+     str     r1, [r0]
+#endif

Where is CONFIG_ONENAND_IPL defined ?
If it is not being used, the #ifndef logic should be reduced.

Quoted 7 lines
Quoted 5 lines

Kyungmin Park sent the patch that is supported onenand_ipl for s5pc1xx. but not yet applied onenand_ipl patch for s5pc1xx.
When that patch is applied, we need these logic.
If necessary, I'll delete these logic until apply the patch.

If the patch already exits, it would be better if it was in this patchset. Can we get the onenand_ipl patch ?

To support the s5pc1xx OneNAND IPL. It needs to refactor the current OneNAND IPL.

Quoted 8 lines

Now I refactor the OneNAND IPL code first and then I will send a OneNAND IPL codes for s5pc1xx.

I want to leave current patch as is. Since If we delete the OneNAND IPL codes. No one can refer the codes. I mean OneNAND IPL parts contains clock and memory configuration. These are helpful to someone who use NAND or NOR.

Yes. Leaving this patch as-is is Ok.

Please refactor the old patch and include it as this patch's dependant in the next revision of s5pc1xx patch set.

Tom

Quoted 2 lines

Thank you,
Kyungmin Park

#13 lore raw

PATCH v4 4/4 s5pc1xx: add support SMDKC100 board

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

Changes since v3:
- add README.s5pc1xx file

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 doc/README.s5pc1xx                     |   56 ++++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
 11 files changed, 923 insertions(+), 0 deletions(-)
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 doc/README.s5pc1xx
 create mode 100644 include/configs/smdkc100.h
MAINTAINERS +4 -0
index f42c8f0..778d5da 100644
@@ -725,6 +725,10 @@ Alex Z
 	lart		SA1100
 	dnp1110		SA1110
 
+Minkyu Kang <[email protected]>
+
+	SMDKC100	ARM CORTEX-A8 (S5PC100 SoC)
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:
MAKEALL +1 -0
index 776f968..a01fb11 100755
@@ -601,6 +601,7 @@ LIST_ARM_CORTEX_A8="		\
 	omap3_pandora		\
 	omap3_zoom1		\
 	omap3_zoom2		\
+	smdkc100		\
 "
 
 #########################################################################
Makefile +3 -0
index 9c5b2a5..eee6649 100644
@@ -3137,6 +3137,9 @@ omap3_zoom1_config :	unconfig
 omap3_zoom2_config :	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
 
+smdkc100_config:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx
+
 #########################################################################
 ## XScale Systems
 #########################################################################
board/samsung/smdkc100/Makefile new file +55 -0

55 lines not on this page · raw message

board/samsung/smdkc100/config.mk new file +16 -0
new file mode 100644
index 0000000..ebab420
@@ -0,0 +1,16 @@
+#
+# Copyright (C) 2008 # Samsung Elecgtronics
+# Kyungmin Park <[email protected]>
+#
+
+# On S5PC100 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x38000000 to 0x40000000 (128MiB)
+#
+# On S5PC110 we use the 128 MiB OneDRAM bank at
+#
+# 0x30000000 to 0x35000000 (80MiB)
+# 0x40000000 to 0x48000000 (128MiB)
+#
+TEXT_BASE = 0x34800000
board/samsung/smdkc100/lowlevel_init.S new file +215 -0

215 lines not on this page · raw message

board/samsung/smdkc100/mem_setup.S new file +197 -0

197 lines not on this page · raw message

board/samsung/smdkc100/onenand.c new file +83 -0

83 lines not on this page · raw message

board/samsung/smdkc100/smdkc100.c new file +51 -0

51 lines not on this page · raw message

doc/README.s5pc1xx new file +56 -0

56 lines not on this page · raw message

include/configs/smdkc100.h new file +242 -0

242 lines not on this page · raw message

Signature · 1 line
1.5.4.3
#14 lore raw

PATCH v4 4/4 s5pc1xx: add support SMDKC100 board

Quoted 32 lines · Minkyu Kang

Adds new board SMDKC100 that uses s5pc100 SoC

---
Changes since v1:
- arrange env values for more readable
- make C struct instead of base+offset
- use MACH_TYPE_SMDKC100 directly
- fix the CONFIG_SYS_HZ to 1000
- enable LOADB, LOADS, BOOTD, XIMG, FPGA

Changes since v2:
- remove <asm/sizes.h> and SZ_XX defines
- remove the define of machine type
- remove the unnecessary comment

Changes since v3:
- add README.s5pc1xx file

 MAINTAINERS                            |    4 +
 MAKEALL                                |    1 +
 Makefile                               |    3 +
 board/samsung/smdkc100/Makefile        |   55 +++++++
 board/samsung/smdkc100/config.mk       |   16 ++
 board/samsung/smdkc100/lowlevel_init.S |  215 ++++++++++++++++++++++++++++
 board/samsung/smdkc100/mem_setup.S     |  197 ++++++++++++++++++++++++++
 board/samsung/smdkc100/onenand.c       |   83 +++++++++++
 board/samsung/smdkc100/smdkc100.c      |   51 +++++++
 doc/README.s5pc1xx                     |   56 ++++++++
 include/configs/smdkc100.h             |  242 ++++++++++++++++++++++++++++++++
 11 files changed, 923 insertions(+), 0 deletions(-)
Quoted 9 lines
 create mode 100644 board/samsung/smdkc100/Makefile
 create mode 100644 board/samsung/smdkc100/config.mk
 create mode 100644 board/samsung/smdkc100/lowlevel_init.S
 create mode 100644 board/samsung/smdkc100/mem_setup.S
 create mode 100644 board/samsung/smdkc100/onenand.c
 create mode 100644 board/samsung/smdkc100/smdkc100.c
 create mode 100644 doc/README.s5pc1xx
 create mode 100644 include/configs/smdkc100.h

applied to u-boot-samsung

Minkyu Kang