Skip to contentSkip to conversation

radio-mr800: remove unnecessary local variable

PATCH In review David Ellingsworth 1 participant 1 message Sep 12, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/10 radio-mr800: remove unnecessary local variable

From f2fdb83ce649e9e69413ab533ec4a84d96850ed4 Mon Sep 17 00:00:00 2001
From: David Ellingsworth <[email protected]>
Date: Sat, 12 Sep 2009 00:19:48 -0400
Subject: [PATCH 04/10] mr800: remove unnecessary local variable

---
drivers/media/radio/radio-mr800.c | 10 ++++------

1 files changed, 4 insertions(+), 6 deletions(-)
drivers/media/radio/radio-mr800.c +0 -0
index d01b96c..fb99c6b 100644
@@ -688,7 +688,6 @@ static int usb_amradio_probe(struct usb_interface *intf,
                const struct usb_device_id *id)
{
    struct amradio_device *radio;
-    struct v4l2_device *v4l2_dev;
    int retval = 0;

    radio = kzalloc(sizeof(struct amradio_device), GFP_KERNEL);
@@ -707,16 +706,15 @@ static int usb_amradio_probe(struct usb_interface *intf,
        goto err_nobuf;
    }
-    v4l2_dev = &radio->v4l2_dev;
-    retval = v4l2_device_register(&intf->dev, v4l2_dev);
+    retval = v4l2_device_register(&intf->dev, &radio->v4l2_dev);
    if (retval < 0) {
        dev_err(&intf->dev, "couldn't register v4l2_device\n");
        goto err_v4l2;
    }

- strlcpy(radio->videodev.name, v4l2_dev->name,
+ strlcpy(radio->videodev.name, radio->v4l2_dev.name,

        sizeof(radio->videodev.name));
-    radio->videodev.v4l2_dev = v4l2_dev;
+    radio->videodev.v4l2_dev = &radio->v4l2_dev;
    radio->videodev.fops = &usb_amradio_fops;
    radio->videodev.ioctl_ops = &usb_amradio_ioctl_ops;
    radio->videodev.release = usb_amradio_video_device_release;
@@ -742,7 +740,7 @@ static int usb_amradio_probe(struct usb_interface *intf,
    return 0;

err_vdev:
- v4l2_device_unregister(v4l2_dev);
+ v4l2_device_unregister(&radio->v4l2_dev);
err_v4l2:

    kfree(radio->buffer);

err_nobuf:

Signature · 1 line
1.6.3.3
Quoted 1 line

From f2fdb83ce649e9e69413ab533ec4a84d96850ed4 Mon Sep 17 00:00:00 2001

From: David Ellingsworth <[email protected]>
Date: Sat, 12 Sep 2009 00:19:48 -0400
Subject: [PATCH 04/10] mr800: remove unnecessary local variable

---
 drivers/media/radio/radio-mr800.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
drivers/media/radio/radio-mr800.c +4 -6
index d01b96c..fb99c6b 100644
@@ -688,7 +688,6 @@ static int usb_amradio_probe(struct usb_interface *intf,
 				const struct usb_device_id *id)
 {
 	struct amradio_device *radio;
-	struct v4l2_device *v4l2_dev;
 	int retval = 0;
 
 	radio = kzalloc(sizeof(struct amradio_device), GFP_KERNEL);
@@ -707,16 +706,15 @@ static int usb_amradio_probe(struct usb_interface *intf,
 		goto err_nobuf;
 	}
 
-	v4l2_dev = &radio->v4l2_dev;
-	retval = v4l2_device_register(&intf->dev, v4l2_dev);
+	retval = v4l2_device_register(&intf->dev, &radio->v4l2_dev);
 	if (retval < 0) {
 		dev_err(&intf->dev, "couldn't register v4l2_device\n");
 		goto err_v4l2;
 	}
 
-	strlcpy(radio->videodev.name, v4l2_dev->name,
+	strlcpy(radio->videodev.name, radio->v4l2_dev.name,
 		sizeof(radio->videodev.name));
-	radio->videodev.v4l2_dev = v4l2_dev;
+	radio->videodev.v4l2_dev = &radio->v4l2_dev;
 	radio->videodev.fops = &usb_amradio_fops;
 	radio->videodev.ioctl_ops = &usb_amradio_ioctl_ops;
 	radio->videodev.release = usb_amradio_video_device_release;
@@ -742,7 +740,7 @@ static int usb_amradio_probe(struct usb_interface *intf,
 	return 0;
 
 err_vdev:
-	v4l2_device_unregister(v4l2_dev);
+	v4l2_device_unregister(&radio->v4l2_dev);
 err_v4l2:
 	kfree(radio->buffer);
 err_nobuf:
Signature · 1 line
1.6.3.3