Skip to contentSkip to conversation

radio-mr800: fix potential use after free

PATCH In review David Ellingsworth 1 participant 2 messages Sep 13, 2009 – Sep 22, 2009

Subsystems (2)
Media (V4L/DVB) MR800 avermedia USB FM radio driver
lore
Share & tools
lore

David Ellingsworth

author
#0 lore raw

PATCH 8/14 radio-mr800: fix potential use after free

From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth <[email protected]>
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free

Signed-off-by David Ellingsworth <[email protected]>

---
drivers/media/radio/radio-mr800.c | 1 -

1 files changed, 0 insertions(+), 1 deletions(-)
drivers/media/radio/radio-mr800.c +0 -1
index 9fd2342..87b58e3 100644
@@ -274,7 +274,6 @@ static void usb_amradio_disconnect(struct usb_interface *intf)
 
    usb_set_intfdata(intf, NULL);
    video_unregister_device(&radio->videodev);
-    v4l2_device_disconnect(&radio->v4l2_dev);

}

/* vidioc_querycap - query device capabilities */

Signature · 1 line
1.6.3.3
Quoted 1 line

From 8c441616f67011244cb15bc1a3dda6fd8706ecd2 Mon Sep 17 00:00:00 2001

From: David Ellingsworth <[email protected]>
Date: Sat, 12 Sep 2009 16:04:44 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free

Signed-off-by David Ellingsworth <[email protected]>
---
 drivers/media/radio/radio-mr800.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/media/radio/radio-mr800.c +0 -1
index 9fd2342..87b58e3 100644
@@ -274,7 +274,6 @@ static void usb_amradio_disconnect(struct usb_interface *intf)
 
 	usb_set_intfdata(intf, NULL);
 	video_unregister_device(&radio->videodev);
-	v4l2_device_disconnect(&radio->v4l2_dev);
 }
 
 /* vidioc_querycap - query device capabilities */
Signature · 1 line
1.6.3.3
author
#1 lore raw

Version 2

From c2c100652ed74d91ade7fdfb2a22d607ff43acf2 Mon Sep 17 00:00:00 2001
From: David Ellingsworth <[email protected]>
Date: Mon, 21 Sep 2009 22:17:05 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free

Signed-off-by David Ellingsworth <[email protected]>

---
drivers/media/radio/radio-mr800.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/radio-mr800.c +1 -1
index 9fd2342..c8fbdde 100644
@@ -273,8 +273,8 @@ static void usb_amradio_disconnect(struct usb_interface *intf)
    mutex_unlock(&radio->lock);
 
    usb_set_intfdata(intf, NULL);
-    video_unregister_device(&radio->videodev);
    v4l2_device_disconnect(&radio->v4l2_dev);
+    video_unregister_device(&radio->videodev);

}

/* vidioc_querycap - query device capabilities */

Signature · 1 line
1.6.4.3
Quoted 1 line

From c2c100652ed74d91ade7fdfb2a22d607ff43acf2 Mon Sep 17 00:00:00 2001

From: David Ellingsworth <[email protected]>
Date: Mon, 21 Sep 2009 22:17:05 -0400
Subject: [PATCH 08/14] mr800: fix potential use after free

Signed-off-by David Ellingsworth <[email protected]>
---
 drivers/media/radio/radio-mr800.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/radio-mr800.c +1 -1
index 9fd2342..c8fbdde 100644
@@ -273,8 +273,8 @@ static void usb_amradio_disconnect(struct usb_interface *intf)
 	mutex_unlock(&radio->lock);
 
 	usb_set_intfdata(intf, NULL);
-	video_unregister_device(&radio->videodev);
 	v4l2_device_disconnect(&radio->v4l2_dev);
+	video_unregister_device(&radio->videodev);
 }
 
 /* vidioc_querycap - query device capabilities */
Signature · 1 line
1.6.4.3