mem.c: could not login on console of fedora 10
When I build and boot -next on fedora 10, I can not login anymore. When I input the user name and password, the system does not output any message and requires user to input the user name and password again and again.
I find the patch which caused this problem with "GIT BISECT" command. And the patch is
commit 7c4b7daa1878972ed0137c95f23569124bd6e2b1 "mem_class: use minor as index instead of searching the array".
Though I don't know the real reason why user could not login, I confirmed the patch I made as following could resolve the problem on fedora 10.
--- drivers/char/mem.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/char/mem.c +2 -2
@@ -878,8 +878,8 @@ static const struct memdev { [ 4] = { "port", &port_fops, NULL }, #endif [ 5] = { "zero", &zero_fops, &zero_bdi }, - [ 6] = { "full", &full_fops, NULL }, - [ 7] = { "random", &random_fops, NULL }, + [ 7] = { "full", &full_fops, NULL }, + [ 8] = { "random", &random_fops, NULL }, [ 9] = { "urandom", &urandom_fops, NULL }, [11] = { "kmsg", &kmsg_fops, NULL }, #ifdef CONFIG_CRASH_DUMP
Signature · 1 line
1.6.2.2
Quoted 36 lines · Jin Dongming
When I build and boot -next on fedora 10, I can not login anymore. When I input the user name and password, the system does not output any message and requires user to input the user name and password again and again.
I find the patch which caused this problem with "GIT BISECT" command. And the patch is
commit7c4b7daa1878972ed0137c95f23569124bd6e2b1"mem_class: use minor as index instead of searching the array".Though I don't know the real reason why user could not login, I confirmed the patch I made as following could resolve the problem on fedora 10.
Signed-off-by Jin Dongming <[email protected]>--- drivers/char/mem.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/char/mem.c +2
-2@@ -878,8 +878,8 @@ static const struct memdev { [ 4] = { "port", &port_fops, NULL }, #endif [ 5] = { "zero", &zero_fops, &zero_bdi }, - [ 6] = { "full", &full_fops, NULL }, - [ 7] = { "random", &random_fops, NULL }, + [ 7] = { "full", &full_fops, NULL }, + [ 8] = { "random", &random_fops, NULL }, [ 9] = { "urandom", &urandom_fops, NULL }, [11] = { "kmsg", &kmsg_fops, NULL }, #ifdef CONFIG_CRASH_DUMPSignature · 1 line
1.6.2.2
I am not entirely sure why I have been CCed on this while the patch author hasn't :) Adding Kay to CC.
Signature · 2 lines
Jiri Kosina SUSE Labs, Novell Inc.
2009/9/14 Jin Dongming <[email protected]>:
Quoted 24 lines
When I build and boot -next on fedora 10, I can not login anymore. When I input the user name and password, the system does not output any message and requires user to input the user name and password again and again.
I find the patch which caused this problem with "GIT BISECT" command. And the patch is
commit7c4b7daa1878972ed0137c95f23569124bd6e2b1"mem_class: use minor as index instead of searching the array".Though I don't know the real reason why user could not login, I confirmed the patch I made as following could resolve the problem on fedora 10.
Signed-off-by Jin Dongming <[email protected]>---
drivers/char/mem.c | 4 ++--1 files changed, 2 insertions(+), 2 deletions(-)drivers/char/mem.c +0
-0
drivers/char/mem.c static const struct memdev { · line 885
Quoted 10 lines
drivers/char/mem.c +2
-2@@ -878,8 +878,8 @@ static const struct memdev { [ 4] = { "port", &port_fops, NULL }, #endif [ 5] = { "zero", &zero_fops, &zero_bdi }, - [ 6] = { "full", &full_fops, NULL }, - [ 7] = { "random", &random_fops, NULL }, + [ 7] = { "full", &full_fops, NULL }, + [ 8] = { "random", &random_fops, NULL }, [ 9] = { "urandom", &urandom_fops, NULL }, [11] = { "kmsg", &kmsg_fops, NULL }, #ifdef CONFIG_CRASH_DUMP
Yeah, that looks messed up and it seems like the right fix. Greg, care to merge that into the patch in your tree?
Thanks for the fix and sorry,
Kay