Skip to contentSkip to conversation

libxfs: increase hash chain depth when we run out of slots

PATCH In review Eric Sandeen 3 participants 3 messages Sep 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxfs: increase hash chain depth when we run out of slots

A couple people reported xfs_repair hangs after "Traversing filesystem ..." in xfs_repair. This happens when all slots in the cache are full and referenced, and the loop in cache_node_get() which tries to shake unused entries fails to find any - it just keeps upping the priority and goes forever.

This can be worked around by restarting xfs_repair with -P and/or "-o bhash=<largersize>" for older xfs_repair.

I started down the path of increasing the number of hash buckets on the fly, but Barry suggested simply increasing the max allowed depth which is much simpler (thanks!)

Resizing the hash lengths does mean that cache_report ends up with most things in the "greater-than" category:

...

Hash buckets with  23 entries      3 (  3%)
Hash buckets with  24 entries      3 (  3%)

Hash buckets with >24 entries 50 ( 85%)

but I think I'll save that fix for another patch unless there's real concern right now.

I tested this on the metadump image provided by Tomek.

---

libxfs/cache.c +21 -0
index 48f91d7..56b24e7 100644
@@ -83,6 +83,18 @@ cache_init(
 }
 
 void
+cache_expand(
+	struct cache *		cache)
+{
+	pthread_mutex_lock(&cache->c_mutex);
+#ifdef CACHE_DEBUG
+	fprintf(stderr, "doubling cache size to %d\n", 2 * cache->c_maxcount);
+#endif
+	cache->c_maxcount *= 2;
+	pthread_mutex_unlock(&cache->c_mutex);
+}
+
+void
 cache_walk(
 	struct cache *		cache,
 	cache_walk_t		visit)
@@ -344,6 +356,15 @@ cache_node_get(
 		if (node)
 			break;
 		priority = cache_shake(cache, priority, 0);
+		/*
+		 * We start at 0; if we free CACHE_SHAKE_COUNT we get
+		 * back the same priority, if not we get back priority+1.
+		 * If we exceed CACHE_MAX_PRIORITY all slots are full; grow it.
+		 */
+		if (priority > CACHE_MAX_PRIORITY) {
+			priority = 0;
+			cache_expand(cache);
+		}
 	}
 
 	node->cn_hashidx = hashidx;

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Eric Sandeen

A couple people reported xfs_repair hangs after "Traversing filesystem ..." in xfs_repair. This happens when all slots in the cache are full and referenced, and the loop in cache_node_get() which tries to shake unused entries fails to find any - it just keeps upping the priority and goes forever.

This can be worked around by restarting xfs_repair with -P and/or "-o bhash=<largersize>" for older xfs_repair.

I started down the path of increasing the number of hash buckets on the fly, but Barry suggested simply increasing the max allowed depth which is much simpler (thanks!)

Resizing the hash lengths does mean that cache_report ends up with most things in the "greater-than" category:

...

Quoted 8 lines
Hash buckets with  23 entries      3 (  3%)
Hash buckets with  24 entries      3 (  3%)

Hash buckets with >24 entries 50 ( 85%)

but I think I'll save that fix for another patch unless there's real concern right now.

I tested this on the metadump image provided by Tomek.

How large is that image? I really think we need to start collecting these images for regression testing.

The patch looks good to me,

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#2 lore raw
Quoted 23 lines · Christoph Hellwig
Quoted 22 lines · Eric Sandeen

A couple people reported xfs_repair hangs after "Traversing filesystem ..." in xfs_repair. This happens when all slots in the cache are full and referenced, and the loop in cache_node_get() which tries to shake unused entries fails to find any - it just keeps upping the priority and goes forever.

This can be worked around by restarting xfs_repair with -P and/or "-o bhash=<largersize>" for older xfs_repair.

I started down the path of increasing the number of hash buckets on the fly, but Barry suggested simply increasing the max allowed depth which is much simpler (thanks!)

Resizing the hash lengths does mean that cache_report ends up with most things in the "greater-than" category:

...

Hash buckets with  23 entries      3 (  3%)
Hash buckets with  24 entries      3 (  3%)

Hash buckets with >24 entries 50 ( 85%)

Quoted 7 lines
Quoted 4 lines

but I think I'll save that fix for another patch unless there's real concern right now.

I tested this on the metadump image provided by Tomek.

How large is that image? I really think we need to start collecting these images for regression testing.

zipped metadump is 170M; unzipped 1.1G.

Crafting a special test fs somehow might be better; maybe with an artificially low bhashsize or something .... yeah, I know. I'm not sure how to manage the regression testing. Working backwards to a minimal testcase on these would be extremely time-consuming and/or impossible I'm afraid.

Quoted 1 line

The patch looks good to me,

thanks for the review

-Eric

Quoted 8 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs