block: blk_set_default_limits sets 0 to max_sectors
Subsystems (2)
PATCH 2/2 block: blk_set_default_limits sets 0 to max_sectors
max_sectors and max_hw_sectors of dm device are set to smaller values than those of underlying devices. E.g:
# cat /sys/block/sdj/queue/max_sectors_kb
512
# cat /sys/block/sdj/queue/max_hw_sectors_kb
32767
# echo "0 10 linear /dev/sdj 0" | dmsetup create test
# cat /sys/block/dm-0/queue/max_sectors_kb
127
# cat /sys/block/dm-0/queue/max_hw_sectors_kb
127
This prevents the I/O size of struct request from becoming large,
and causes undesired request fragmentation in request-based dm.This is caused by the queue_limits stacking.
In dm_calculate_queue_limits(), the block-layer's safe default value (SAFE_MAX_SECTORS, 255) is included in the merging process of target's queue_limits. So underlying queue_limits is not propagated correctly.
Initialize default values of all max_sectors to '0'
in blk_set_default_limits() so that the values propagate properly from underlying devices.
Check this thread for further background:
https://www.redhat.com/archives/dm-devel/2009-September/msg00176.html
Signed-off-by Kiyoshi Ueda <[email protected]>
Signed-off-by Jun'ichi Nomura <[email protected]>
Reported-by David Strand <[email protected]>
Cc Mike Snitzer <[email protected]>
Cc Alasdair G Kergon <[email protected]>
Cc Martin K. Petersen <[email protected]>
Cc Jens Axboe <[email protected]>
--- block/blk-settings.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
block/blk-settings.c +2 -1
@@ -111,7 +111,7 @@ void blk_set_default_limits(struct queue lim->max_hw_segments =MAX_HW_SEGMENTS ; lim->seg_boundary_mask =BLK_SEG_BOUNDARY_MASK ; lim->max_segment_size =MAX_SEGMENT_SIZE ; - lim->max_sectors = lim->max_hw_sectors =SAFE_MAX_SECTORS ; + lim->max_sectors = lim->max_hw_sectors =0 ; lim->logical_block_size = lim->physical_block_size = lim->io_min =512 ; lim->bounce_pfn = (unsigned long )(BLK_BOUNCE_ANY >>PAGE_SHIFT ); lim->alignment_offset =0 ;
@@ -164,6 +164,7 @@ void blk_queue_make_request(struct reque q->unplug_timer.data = (unsigned long )q;blk_set_default_limits (&q->limits); +blk_queue_max_sectors (q,SAFE_MAX_SECTORS );/* * If the caller didn't supply a lock, fall back to our embedded