Skip to contentSkip to conversation

support command string with space

RFC PATCH New Takahiro Yasui 3 participants 6 messages Sep 30, 2009 – Oct 16, 2009

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/5 support command string with space

Support escaped space by backslash in the command line string passed through lvm2 command interface, lvm2_run(). This is used to handle "--config" option which contains multiple parameters.

e.g. lvconvert --repair --use-policies --config \
     devices{ignore_suspended_devices=1\ filter=[...]} vg/lv
---
 tools/lvmcmdline.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
tools/lvmcmdline.c +8 -1
Index: LVM2.02.54-20090928/tools/lvmcmdline.c
===================================================================
@@ -1070,8 +1070,15 @@ int lvm_split(char *str, int *argc, char
 			break;
 
 		e = b;
-		while (*e && !isspace(*e))
+		while (*e && !isspace(*e)) {
+			/*
+			 * 'backslash' is treated as a escape character
+			 * and the string isn't split at 'backslash + space.'
+			 */
+			if (*e == '\\' && isspace(*(e+1)))
+				*e++ = ' ';
 			e++;
+		}
 
 		argv[(*argc)++] = b;
 		if (!*e)
Signature · 2 lines
Takahiro Yasui
Hitachi Computer Products (America), Inc.
#1 lore raw

RFC PATCH 1/5 support command string with space

Quoted 24 lines · Takahiro Yasui

Support escaped space by backslash in the command line string passed through lvm2 command interface, lvm2_run(). This is used to handle "--config" option which contains multiple parameters.

e.g. lvconvert --repair --use-policies --config \
     devices{ignore_suspended_devices=1\ filter=[...]} vg/lv
---
 tools/lvmcmdline.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Index: LVM2.02.54-20090928/tools/lvmcmdline.c
===================================================================

tools/lvmcmdline.c +2 -1
@@ -1070,8 +1070,15 @@ int lvm_split(char *str, int *argc, char
 			break;
 
 		e = b;
-		while (*e && !isspace(*e))
+		while (*e && !isspace(*e)) {
+			/*

tools/lvmcmdline.c int lvm_split(char *str, int *argc, char · line 1084

Quoted 10 lines
tools/lvmcmdline.c +6 -0
+			 * 'backslash' is treated as a escape character
+			 * and the string isn't split at 'backslash + space.'
+			 */
+			if (*e == '\\' && isspace(*(e+1)))
+				*e++ = ' ';
 			e++;
+		}
 
 		argv[(*argc)++] = b;
 		if (!*e)

IIUIC, the code will replace "\ " with " " (double space) -- which may or may not be correct, depending on where the space appears. It also breaks any code that may have previously expected "\ " to have no special meaning, even though I doubt any exists.

Anyway, a more correct solution would entail a lvm2_runv (or similarly named) function, that would take char **argv -- no escaping issues to care about. Since this just adds to the library, it should be backwards compatible just fine.

Yours,
Petr.

#2 lore raw

RFC PATCH 1/5 support command string with space

Quoted 34 lines · Petr Rockai
Quoted 32 lines · Takahiro Yasui

Support escaped space by backslash in the command line string passed through lvm2 command interface, lvm2_run(). This is used to handle "--config" option which contains multiple parameters.

e.g. lvconvert --repair --use-policies --config \
     devices{ignore_suspended_devices=1\ filter=[...]} vg/lv
---
 tools/lvmcmdline.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Index: LVM2.02.54-20090928/tools/lvmcmdline.c
===================================================================

tools/lvmcmdline.c +8 -1
@@ -1070,8 +1070,15 @@ int lvm_split(char *str, int *argc, char
 			break;
 
 		e = b;
-		while (*e && !isspace(*e))
+		while (*e && !isspace(*e)) {
+			/*
+			 * 'backslash' is treated as a escape character
+			 * and the string isn't split at 'backslash + space.'
+			 */
+			if (*e == '\\' && isspace(*(e+1)))
+				*e++ = ' ';
 			e++;
+		}
 
Quoted 6 lines

tools/lvmcmdline.c int lvm_split(char *str, int *argc, char · line 1084

Quoted 2 lines
tools/lvmcmdline.c +0 -0
 		argv[(*argc)++] = b;
 		if (!*e)

IIUIC, the code will replace "\ " with " " (double space) -- which may or may not be correct, depending on where the space appears. It also breaks any code that may have previously expected "\ " to have no special meaning, even though I doubt any exists.

Yes, this approach replace "\ " with " ", and it will work correctly unless "\ " is used for other purpose previously. Current lvm codes use lvm_split() only in early stage to split options and there is no case you concerns.

Quoted 4 lines

Anyway, a more correct solution would entail a lvm2_runv (or similarly named) function, that would take char **argv -- no escaping issues to care about. Since this just adds to the library, it should be backwards compatible just fine.

I can add an interface like lvm2_runv. But there is another approach using single-quotes around an option with spaces as we do in a shell (e.g. bash).

Thanks,
Taka

#3 lore raw

RFC PATCH 1/5 support command string with space

Quoted 9 lines · Takahiro Yasui
Quoted 4 lines · Petr Rockai

IIUIC, the code will replace "\ " with " " (double space) -- which may or may not be correct, depending on where the space appears. It also breaks any code that may have previously expected "\ " to have no special meaning, even though I doubt any exists.

Yes, this approach replace "\ " with " ", and it will work correctly unless "\ " is used for other purpose previously. Current lvm codes use lvm_split() only in early stage to split options and there is no case you concerns.

There may not be *right now* -- I still think this is a bug waiting to happen. Shell scripts are full of escaping bugs and in dmeventd we have a simple way around (see below). One example for all -- I know it may be sick, but you can have device node paths with spaces in them, and I expect this will break -- either you forget to escape them, or the un-escaping produces wrong paths. (And as surprising as it may sound, spaces in device names work with current code -- I can create PVs and VGs on them and I can filter them out or in.)

Quoted 7 lines
Quoted 4 lines

Anyway, a more correct solution would entail a lvm2_runv (or similarly named) function, that would take char **argv -- no escaping issues to care about. Since this just adds to the library, it should be backwards compatible just fine.

I can add an interface like lvm2_runv. But there is another approach using single-quotes around an option with spaces as we do in a shell (e.g. bash).

And how you quote single-quotes then? Doesn't work. Please use something reliable and robust -- like passing argv, or using varargs function (like execl). This eliminates all quoting bugs quite simply.

Yours,
Petr.

#5 lore raw

RFC PATCH 1/5 support command string with space

In reply to Petr Rockai
Quoted 4 lines · Peter Rockai

Anyway, a more correct solution would entail a lvm2_runv (or similarly named) function, that would take char **argv -- no escaping issues to care about. Since this just adds to the library, it should be backwards compatible just fine.

Yes - try a lvm2_runv() first, that simply bypasses the call to lvm_split().

Alasdair

#4 lore raw

RFC PATCH 1/5 support command string with space

In reply to Petr Rockai
Quoted 24 lines · Petr Rockai
Quoted 9 lines · Takahiro Yasui
Quoted 4 lines · Petr Rockai

IIUIC, the code will replace "\ " with " " (double space) -- which may or may not be correct, depending on where the space appears. It also breaks any code that may have previously expected "\ " to have no special meaning, even though I doubt any exists.

Yes, this approach replace "\ " with " ", and it will work correctly unless "\ " is used for other purpose previously. Current lvm codes use lvm_split() only in early stage to split options and there is no case you concerns.

There may not be *right now* -- I still think this is a bug waiting to happen. Shell scripts are full of escaping bugs and in dmeventd we have a simple way around (see below). One example for all -- I know it may be sick, but you can have device node paths with spaces in them, and I expect this will break -- either you forget to escape them, or the un-escaping produces wrong paths. (And as surprising as it may sound, spaces in device names work with current code -- I can create PVs and VGs on them and I can filter them out or in.)

Quoted 5 lines
Quoted 4 lines

Anyway, a more correct solution would entail a lvm2_runv (or similarly named) function, that would take char **argv -- no escaping issues to care about. Since this just adds to the library, it should be backwards compatible just fine.

Quoted 5 lines
Quoted 2 lines

I can add an interface like lvm2_runv. But there is another approach using single-quotes around an option with spaces as we do in a shell (e.g. bash).

And how you quote single-quotes then? Doesn't work. Please use something reliable and robust -- like passing argv, or using varargs function (like execl). This eliminates all quoting bugs quite simply.

I see. Your approach, lvm2_runv, seems quite safe, and I will implement it. Thank you for the helpful comments.

Thanks,
Taka