pac7311: remove magic value for USB_BUF_SZ

PATCH New Németh Márton 1 participant 1 message Oct 3, 2009 Media (V4L/DVB)

lore

Share & tools

lore

Németh Márton

author

2009-10-03 07:35 UTC #0 lore raw

PATCH 3/3 pac7311: remove magic value for USB_BUF_SZ

From: Márton Németh <[email protected]>

The length check in reg_w_var() function is because the buffer contents is copied to gspca_dev->usb_buf which has the size of USB_BUF_SZ bytes as defined in drivers/media/video/gspca/gspca.h. Replace the number with symbol for better readability and maintainability.

The change was tested with Labtec Webcam 2200.

Signed-off-by Márton Németh <[email protected]>

---

drivers/media/video/gspca/pac7311.c +1 -1

diff -upr c/drivers/media/video/gspca/pac7311.c d/drivers/media/video/gspca/pac7311.c
@@ -474,7 +474,7 @@ static void reg_w_var(struct gspca_dev *
 			reg_w_page(gspca_dev, page3_7302, sizeof page3_7302);
 			break;
 		default:
-			if (len > 64) {
+			if (len > USB_BUF_SZ) {
 				PDEBUG(D_ERR|D_STREAM,
 					"Incorrect variable sequence");
 				return;