Skip to contentSkip to conversation

acerhdf: Limit modalias matching to supported boards]

PATCH Superseded Stefan Bader 3 participants 10 messages Oct 5, 2009 – Nov 9, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acerhdf: Limit modalias matching to supported boards]

Len,

could you please pick this patch to prevent the acerhdf module to get loaded on the wrong hardware (causing only annoying warnings.

Thanks,
Stefan

-------- Original Message --------
Subject: Re: [PATCH] acerhdf: Limit modalias matching to supported boards
Date: Sat, 03 Oct 2009 18:47:33 +0200
From: Peter Feuerer <[email protected]>
To: Stefan Bader <[email protected]>
CC: Borislav Petkov <[email protected]>, [email protected]
References: <[email protected]> <[email protected]> <cone.1254466252.404216.3290.1000@onepiie> <[email protected]> <[email protected]> <cone.1254477850.9043.3499.1000@onepiie> <[email protected]>

Quoted 25 lines · Stefan Bader
Quoted 24 lines · Peter Feuerer
Quoted 22 lines · Borislav Petkov
Quoted 20 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

Quoted 5 lines

We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?

Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.

IMO, we should just go ahead send it to Len. Stefan, you have my ACK.

Thank you Stefan!

regards,
--peter

Signature · 1 line
When all other means of communication fail, try words!
author Acked-by Borislav Petkov Acked-by Peter Feuerer on v1 1/1
#1 lore raw
Quoted 47 lines · Stefan Bader

Len,

could you please pick this patch to prevent the acerhdf module to get loaded on the wrong hardware (causing only annoying warnings.

Thanks,
Stefan

-------- Original Message --------
Subject: Re: [PATCH] acerhdf: Limit modalias matching to supported boards
Date: Sat, 03 Oct 2009 18:47:33 +0200
From: Peter Feuerer <[email protected]>
To: Stefan Bader <[email protected]>
CC: Borislav Petkov <[email protected]>, [email protected]
References: <[email protected]> <[email protected]> <cone.1254466252.404216.3290.1000@onepiie> <[email protected]> <[email protected]> <cone.1254477850.9043.3499.1000@onepiie> <[email protected]>

Quoted 30 lines · Stefan Bader
Quoted 29 lines · Peter Feuerer
Quoted 27 lines · Borislav Petkov
Quoted 17 lines · Stefan Bader
Quoted 11 lines
Quoted 1 line

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

Quoted 5 lines

We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?

Quoted 3 lines

Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.

Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

IMO, we should just go ahead send it to Len. Stefan, you have my ACK.

Thank you Stefan!

regards,
--peter

Doh! This time _with_ the patch...

Signature · 1 line
When all other means of communication fail, try words!
Quoted 1 line

From 60cdb7bea856fdd594262ee1e9608cd2210cf196 Mon Sep 17 00:00:00 2001

From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards

The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell.

---
 drivers/platform/x86/acerhdf.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/acerhdf.c +4 -3
index 0a8f735..23eea4c 100644
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
-MODULE_ALIAS("dmi:*:*Gateway*:*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
 
 module_init(acerhdf_init);
 module_exit(acerhdf_exit);
Signature · 1 line
1.5.4.3
#2 lore raw
Quoted 29 lines · Stefan Bader
Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 29 lines
Quoted 27 lines · <[email protected]> wrote:
Quoted 13 lines
Quoted 2 lines

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll
hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

Quoted 8 lines

We have exactly those constellations within the BIOS settings table. If I
interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I
think we do already have all information we need to create a complete patch
for the problem, or am I wrong?

Right pn means that. I would strongly believe the above changes should be
good. I sometimes tend to be over-cautious. Attaching a refreshed patch
which includes them all.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.

This smells like a maintenance problem. The driver only works on the specific machines and BIOS versions compiled into it. That means you have to update the driver every time a new machine comes out. A major goal of ACPI is to avoid stuff like that.

Are you sure there's no way to make this driver work in a generic way, e.g., by claiming an ACPI device?

I can't believe that Windows would tolerate a solution like this, although I guess maybe people are using to having to install Windows, then install random OEM-specific junk on top to get full functionality, and OEMs can probably do whatever ugly things they want there.

Or is this another case of "the OS is supposed to use WMI to do this, and no, you can't have the WMI information"?

Bjorn

#3 lore raw
Quoted 26 lines · Bjorn Helgaas
Quoted 17 lines · Stefan Bader
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Quoted 16 lines · <[email protected]> wrote:
Quoted 16 lines
Quoted 1 line

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

We have exactly those constellations within the BIOS settings table. If I interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I think we do already have all information we need to create a complete patch for the problem, or am I wrong?

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines

Right pn means that. I would strongly believe the above changes should be good. I sometimes tend to be over-cautious. Attaching a refreshed patch which includes them all.

Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.

Quoted 7 lines

This smells like a maintenance problem. The driver only works on the specific machines and BIOS versions compiled into it. That means you have to update the driver every time a new machine comes out. A major goal of ACPI is to avoid stuff like that.

Are you sure there's no way to make this driver work in a generic way, e.g., by claiming an ACPI device?

The driver is currently only targeted at a small set of netbooks and even there some registers have changed between sub models or bios versions.
The functions are implemented by poking and reading bits from the EC. No acpi interface to which one relate as far as I know. Maybe wmi, but from the experiences with acer-wmi, I doubt anything works. At least acer-wmi now explicitly blacklist these models for uselessness. So the driver performs very strict bios version checks and every unknown version get a big warning printed. Which you do not want to be issued on every hardware of one of these vendors. Which happens with the driver as it is now.

-Stefan

Quoted 13 lines

I can't believe that Windows would tolerate a solution like this, although I guess maybe people are using to having to install Windows, then install random OEM-specific junk on top to get full functionality, and OEMs can probably do whatever ugly things they want there.

Or is this another case of "the OS is supposed to use WMI to do this, and no, you can't have the WMI information"?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
When all other means of communication fail, try words!
#4 lore raw
Quoted 42 lines · Stefan Bader
Quoted 33 lines · Bjorn Helgaas
Quoted 27 lines · Stefan Bader
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 26 lines · <[email protected]> wrote:
Quoted 13 lines
Quoted 2 lines

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll
hopefully find some time upcoming weekend.

But, can't we simply assume, following dmi lines?

MODULE_ALIAS("dmi:*:*Acer*:*AOA*:");
MODULE_ALIAS("dmi:*:*Gateway*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*AOA*:");
MODULE_ALIAS("dmi:*:*Packard Bell*:*DOA*:");

Quoted 8 lines

We have exactly those constellations within the BIOS settings table. If I
interpret the modalias line correctly, "pnAOA110" means "Product Name AOA110" and that's what we have already in the BIOS settings table. So I
think we do already have all information we need to create a complete patch
for the problem, or am I wrong?

Right pn means that. I would strongly believe the above changes should be
good. I sometimes tend to be over-cautious. Attaching a refreshed patch
which includes them all.

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Well, acerhdf.c and dmi-id.c both do dmi_get_system_info(DMI_PRODUCT_NAME) when querying product name which means that the product names in the acerhdf table and the dmi-id ones are actually one and the same thing.

Quoted 7 lines

This smells like a maintenance problem. The driver only works on the specific machines and BIOS versions compiled into it. That means you have to update the driver every time a new machine comes out. A major goal of ACPI is to avoid stuff like that.

Are you sure there's no way to make this driver work in a generic way, e.g., by claiming an ACPI device?

Quoted 9 lines

The driver is currently only targeted at a small set of netbooks and even there some registers have changed between sub models or bios versions. The functions are implemented by poking and reading bits from the EC. No acpi interface to which one relate as far as I know. Maybe wmi, but from the experiences with acer-wmi, I doubt anything works. At least acer-wmi now explicitly blacklist these models for uselessness.
So the driver performs very strict bios version checks and every unknown version get a big warning printed. Which you do not want to be issued on every hardware of one of these vendors. Which happens with the driver as it is now.

I understand the motivation for the current patch, and I'm not asking about it in particular. My concern is about the underlying structure of the driver.

I'm just asking why we would want a driver that requires an update for every new machine. That sort of ongoing maintenance is a good sign that we're doing something wrong.

Bjorn

maintainer
#5 lore raw

Re: [PATCH] acerhdf: Limit modalias matching to supported boards

Quoted 6 lines · Bjorn Helgaas
Quoted 5 lines · Stefan Bader
Quoted 4 lines · Bjorn Helgaas
Quoted 3 lines · Stefan Bader
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines · <[email protected]> wrote:
Quoted 2 lines
Quoted 1 line

I search my acerhdf-inbox for the people who sent me the BIOS versions,

maybe they still have the netbook and can me send the modalias content. I'll

...

Quoted 13 lines
Quoted 6 lines
Quoted 6 lines

This smells like a maintenance problem. The driver only works on the specific machines and BIOS versions compiled into it. That means you have to update the driver every time a new machine comes out. A major goal of ACPI is to avoid stuff like that.

Quoted 6 lines
Quoted 2 lines

Are you sure there's no way to make this driver work in a generic way, e.g., by claiming an ACPI device?

The driver is currently only targeted at a small set of netbooks and even there some registers have changed between sub models or bios versions.
The functions are implemented by poking and reading bits from the EC. No acpi interface to which one relate as far as I know. Maybe wmi, but from the experiences with acer-wmi, I doubt anything works. At least acer-wmi now explicitly blacklist these models for uselessness. So the driver performs very strict bios version checks and every unknown version get a big warning printed. Which you do not want to be issued on every hardware of one of these vendors. Which happens with the driver as it is now.

Quoted 7 lines

I understand the motivation for the current patch, and I'm not asking about it in particular. My concern is about the underlying structure of the driver.

I'm just asking why we would want a driver that requires an update for every new machine. That sort of ongoing maintenance is a good sign that we're doing something wrong.

Hi Bjorn,

as Stefan already mentioned, is the driver only targeting a very small set of (very popular) netbooks. The vendor supposed to control the fan only by BIOS. I think it is not ment to be controlled by the OS at all, as there is no official Windows support neither. The successor series of the supported netbooks even don't have the register in EC anymore. So I think there won't be much changes caused by new devices in the future anymore. Besides that, I don't think there's a way to detect the right register and the needed values automatically…

kind regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw

PATCH RESEND 1/1 acerhdf: Limit modalias matching to supported boards

In reply to Stefan Bader

Hi Len,

could you please add the following patch to acpi-testing. Thanks.

Stefan

Quoted 1 line

From 230e81c3440cdfc5f931755cece4f1181a3b1374 Mon Sep 17 00:00:00 2001

From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards

The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell.

---
 drivers/platform/x86/acerhdf.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/acerhdf.c +4 -3
index aa298d6..890976f 100644
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
-MODULE_ALIAS("dmi:*:*Gateway*:*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
 
 module_init(acerhdf_init);
 module_exit(acerhdf_exit);
Signature · 1 line
1.6.3.3
maintainer
#7 lore raw

Re: [PATCH][RESEND] acerhdf: Limit modalias matching to supported boards

Hi Stefan,

you should send your email with the patch properly formated. E.g. inline instead of attaching it. Have a look into Documentation/email-clients.txt

kind regards
--peter

Quoted 7 lines · Stefan Bader

Hi Len,

could you please add the following patch to acpi-testing. Thanks.

Stefan

author Acked-by Borislav Petkov Acked-by Peter Feuerer
#8 lore raw

Re: [PATCH][RESEND] acerhdf: Limit modalias matching to supported

Inlined patch version

-Stefan

Quoted 1 line

From 230e81c3440cdfc5f931755cece4f1181a3b1374 Mon Sep 17 00:00:00 2001

From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards

The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell.

---
 drivers/platform/x86/acerhdf.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/acerhdf.c +4 -3
index aa298d6..890976f 100644
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
-MODULE_ALIAS("dmi:*:*Gateway*:*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
 
 module_init(acerhdf_init);
 module_exit(acerhdf_exit);
Signature · 1 line
1.6.3.3
#9 lore raw

Re: [PATCH][RESEND] acerhdf: Limit modalias matching to supported

Len,

could you please apply the patch mentioned or help me to understand what I need to do, in order to correctly submit them?

Thanks,
Stefan

Quoted 42 lines · Stefan Bader

Inlined patch version

-Stefan

From 230e81c3440cdfc5f931755cece4f1181a3b1374 Mon Sep 17 00:00:00 2001
From: Stefan Bader <[email protected]>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] acerhdf: Limit modalias matching to supported boards

The module alias currently matches any Acer computer but when loaded the BIOS checks will only succeed on Aspire One models. This causes a invalid BIOS warning for all other models (seen on Aspire 4810T). This is not fatal but worries users that see this message. Limiting the moule alias to models starting with AOA or DOA for Packard Bell.

---
 drivers/platform/x86/acerhdf.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
drivers/platform/x86/acerhdf.c +4 -3
index aa298d6..890976f 100644
@@ -629,9 +629,10 @@ static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
-MODULE_ALIAS("dmi:*:*Gateway*:*:");
-MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
+MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
 
 module_init(acerhdf_init);
 module_exit(acerhdf_exit);