Skip to contentSkip to conversation

mac80211: use kfree_skb() to free struct sk_buff pointers

PATCH In review Roel Kluin 3 participants 3 messages Oct 6, 2009 mac80211

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 mac80211: use kfree_skb() to free struct sk_buff pointers

kfree_skb() should be used to free struct sk_buff pointers.

Signed-off-by Roel Kluin <[email protected]>

---

net/mac80211/util.c +2 -2
index dd65643..aeb65b3 100644
@@ -339,7 +339,7 @@ void ieee80211_add_pending_skb(struct ieee80211_local *local,
 	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 
 	if (WARN_ON(!info->control.vif)) {
-		kfree(skb);
+		kfree_skb(skb);
 		return;
 	}
 

@@ -367,7 +367,7 @@ int ieee80211_add_pending_skbs(struct ieee80211_local *local,
 		struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 
 		if (WARN_ON(!info->control.vif)) {
-			kfree(skb);
+			kfree_skb(skb);
 			continue;
 		}
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Roel Kluin

kfree_skb() should be used to free struct sk_buff pointers.

Signed-off-by Roel Kluin <[email protected]>

Indeed, thanks.

Acked-by Johannes Berg <[email protected]>
Quoted 24 lines

---

net/mac80211/util.c +2 -2
index dd65643..aeb65b3 100644
@@ -339,7 +339,7 @@ void ieee80211_add_pending_skb(struct ieee80211_local *local,
 	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 
 	if (WARN_ON(!info->control.vif)) {
-		kfree(skb);
+		kfree_skb(skb);
 		return;
 	}
 

@@ -367,7 +367,7 @@ int ieee80211_add_pending_skbs(struct ieee80211_local *local,
 		struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 
 		if (WARN_ON(!info->control.vif)) {
-			kfree(skb);
+			kfree_skb(skb);
 			continue;
 		}