ucb1x00 patches
Hi,
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on moving ucb1x00-ts.c to
input/drivers/touchscreen.
Regards,
Thomas
Hi,
Quoted 8 lines · Thomas Kunze
Hi,
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on movingucb1x00-ts.cto
input/drivers/touchscreen.
What about the ucb1400_ts.c which is already there?
Lothar Wa?mann
Signature · 9 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________
Dne St 7. ??jna 2009 09:13:22 Lothar Wa?mann napsal(a):
Quoted 5 lines
Hi,
Quoted 2 lines · Thomas Kunze
Hi,
Quoted 8 lines
Quoted 5 lines
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on movingucb1x00-ts.cto
input/drivers/touchscreen.What about the
ucb1400_ts.cwhich is already there?
I'd be for unifying all the ucb drivers into a single one, but Russell was against it iirc.
Quoted 3 lines
Lothar Wa?mann
Quoted 12 lines · Marek Vasut
Dne St 7. ??jna 2009 09:13:22 Lothar Wa?mann napsal(a):
Quoted 11 lines
Hi,
Quoted 7 lines · Thomas Kunze
Hi,
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on movingucb1x00-ts.cto
input/drivers/touchscreen.
Quoted 5 lines
Quoted 2 lines
What about the
ucb1400_ts.cwhich is already there?I'd be for unifying all the ucb drivers into a single one, but Russell was against it iirc.
They're different beasts, and I really don't think they should be unified. They have different register layouts, and different access arrangements, which need different handling.
The result is that the UCB1200/UCB1300 support gets unnecessarily penalised when UCB1400 is integrated - instead of merely taking a spinlock and accessing the register, you have to ensure everything you do is in thread context, including interrupt handlers.
Quoted 19 lines · Russell King - ARM Linux
Quoted 12 lines · Marek Vasut
Dne St 7. ????jna 2009 09:13:22 Lothar Wa??mann napsal(a):
Quoted 11 lines
Hi,
Quoted 7 lines · Thomas Kunze
Hi,
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on movingucb1x00-ts.cto
input/drivers/touchscreen.Quoted 5 lines
Quoted 2 lines
What about the
ucb1400_ts.cwhich is already there?I'd be for unifying all the ucb drivers into a single one, but Russell was against it iirc.
Quoted 8 lines
They're different beasts, and I really don't think they should be unified. They have different register layouts, and different access arrangements, which need different handling.
The result is that the UCB1200/UCB1300 support gets unnecessarily penalised when UCB1400 is integrated - instead of merely taking a spinlock and accessing the register, you have to ensure everything you do is in thread context, including interrupt handlers.
Is it that bad?
If sharing makes sense on source-code level, that kind of penalty should be acceptable. If it makes more eyes on the sources, it will still be a win.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 29 lines · Pavel Machek
Quoted 19 lines · Russell King - ARM Linux
Quoted 12 lines · Marek Vasut
Dne St 7. ????jna 2009 09:13:22 Lothar Wa??mann napsal(a):
Quoted 11 lines
Hi,
Quoted 7 lines · Thomas Kunze
Hi,
I posted these patches at linux-arm-kernel as part of the patchset "collie and SA1100 patches".
Could you please comment on them? I'd also like to know you opinion on movingucb1x00-ts.cto
input/drivers/touchscreen.Quoted 5 lines
Quoted 2 lines
What about the
ucb1400_ts.cwhich is already there?I'd be for unifying all the ucb drivers into a single one, but Russell was against it iirc.
Quoted 8 lines
They're different beasts, and I really don't think they should be unified. They have different register layouts, and different access arrangements, which need different handling.
The result is that the UCB1200/UCB1300 support gets unnecessarily penalised when UCB1400 is integrated - instead of merely taking a spinlock and accessing the register, you have to ensure everything you do is in thread context, including interrupt handlers.
Quoted 5 lines
Is it that bad?
If sharing makes sense on source-code level, that kind of penalty should be acceptable. If it makes more eyes on the sources, it will still be a win.
That argument doesn't always apply. It is only a win if you have lots of people testing the code out on *both* chips, so that bugs are discovered quickly.
The UCB1200/1300 support is stable and good. Don't break it by totally changing the way it works just for the sake of a wooley "more eyes must be good" flimsy argument.