sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start()

PATCH Applied Roel Kluin 2 participants 2 messages Oct 6, 2009 – Oct 13, 2009

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-10-06 19:59 UTC #0 lore raw

PATCH 1/1 sb1250-mac: duplicate setting of bit V_MAC_RX_PL_THRSH(4) in sbmac_channel_start()

The bit V_MAC_RX_PL_THRSH(4) was already set a few lines higher.

Signed-off-by Roel Kluin <[email protected]>

---
Please review. Maybe it should be replaced by something else?

drivers/net/sb1250-mac.c +0 -1

index 508551f..7269a87 100644
@@ -1476,7 +1476,6 @@ static void sbmac_channel_start(struct sbmac_softc *s)
 		V_MAC_TX_RL_THRSH(4) |
 		V_MAC_RX_PL_THRSH(4) |
 		V_MAC_RX_RD_THRSH(4) |	/* Must be '4' */
-		V_MAC_RX_PL_THRSH(4) |
 		V_MAC_RX_RL_THRSH(8) |
 		0;

David Miller

maintainer Applied

2009-10-13 10:48 UTC #1 lore raw

From: Roel Kluin <[email protected]>
Date: Tue, 06 Oct 2009 22:07:15 +0200

Quoted 5 lines

The bit V_MAC_RX_PL_THRSH(4) was already set a few lines higher.
Signed-off-by Roel Kluin <[email protected]>
---
Please review. Maybe it should be replaced by something else?

Maybe, but or'ing it in twice is definitely pointless.

Applied to net-next-2.6, thanks.