FEATURES prints
Subsystems (3)
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : Y
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
any comments?
Signature · 2 lines
Regards, Nishanth Menon
Quoted 15 lines
-----Original Message-----
From: Menon, Nishanth
Sent: Friday, October 09, 2009 12:43 AM
To: Premi, Sanjeev; [email protected]
Subject: FEATURES printsFolks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : Y
Quoted 2 lines
comes up on SDP3430 -> now that we will introduce half a dozen features
[sp] The intention here is to print the features that help in
identifying the processor. Not really the board/EVM. Even if there are more features, we decide which ones to show.
Quoted 2 lines
here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
[sp] I believe the sysfs would be good for board level features.
Quoted 7 lines
any comments?
Signature · 2 lines
Regards, Nishanth Menon
Premi, Sanjeev had written, on 10/09/2009 05:46 AM, the following:
Quoted 14 lines
Quoted 14 lines
-----Original Message-----
From: Menon, Nishanth Sent: Friday, October 09, 2009 12:43 AM
To: Premi, Sanjeev; [email protected]
Subject: FEATURES printsFolks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : Y
Quoted 6 lines
Quoted 1 line
comes up on SDP3430 -> now that we will introduce half a dozen features
[sp] The intention here is to print the features that help in
identifying the processor. Not really the board/EVM. Even if there are more features, we decide which ones to show.
this still a bunch of noise which is unusable for applications -> e.g. if an app wanted to use ISP, how would it do it?
Signature · 2 lines
Regards, Nishanth Menon
Quoted 26 lines
-----Original Message-----
From: Menon, Nishanth
Sent: Friday, October 09, 2009 7:45 PM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: FEATURES printsPremi, Sanjeev had written, on 10/09/2009 05:46 AM, the following:
Quoted 18 lines
Quoted 17 lines
-----Original Message-----
From: Menon, Nishanth
Sent: Friday, October 09, 2009 12:43 AM
To: Premi, Sanjeev; [email protected]
Subject: FEATURES printsFolks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : Ycomes up on SDP3430 -> now that we will introduce half a dozen features
Quoted 7 lines
Quoted 4 lines
[sp] The intention here is to print the features that help in
identifying the processor. Not really the board/EVM. Even if there are more features, we decide which ones to show.this still a bunch of noise which is unusable for
applications -> e.g.
if an app wanted to use ISP, how would it do it?
[sp] At this stage, they help in identifying the variants in the OMAP35x family.
~sanjeev
Quoted 6 lines
Signature · 3 lines
-- Regards, Nishanth Menon
Quoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : Y
Quoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Even with this, I think adding the display of these features into an OMAP-specific section of /proc/cpuinfo would be even better.
Comments?
Kevin
commit 24f7422bad970cea2ed71d71e3994eeed70f175f
Author: Kevin Hilman <[email protected]> Date: Tue Oct 13 14:42:00 2009 -0700
OMAP3: collapse chip feature prints to single line
arch/arm/mach-omap2/id.c +4 -6
@@ -249,11 +249,8 @@ void __init omap3_check_revision(void) }#define OMAP3_SHOW_FEATURE (feat) \ - if (omap3_has_ ##feat()) { \ - pr_info (" - "#feat" : Y"); \ - } else { \ - pr_info (" - "#feat" : N"); \ - } + if (omap3_has_ ##feat()) \ + printk (#feat" "); \void __init omap3_cpuinfo (void ) {
@@ -307,13 +304,14 @@ void __init omap3_cpuinfo(void)/* * Print verbose information */ -pr_info ("OMAP%s ES%s\n" , cpu_name, cpu_rev); +pr_info ("OMAP%s ES%s (" , cpu_name, cpu_rev);OMAP3_SHOW_FEATURE (l2cache);OMAP3_SHOW_FEATURE (iva);OMAP3_SHOW_FEATURE (sgx);OMAP3_SHOW_FEATURE (neon);OMAP3_SHOW_FEATURE (isp); +printk (")\n" ); }/*
Quoted 27 lines
-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, October 14, 2009 3:17 AM
To: Menon, Nishanth
Cc: Premi, Sanjeev; [email protected]
Subject: Re: FEATURES printsQuoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : YQuoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
Quoted 9 lines
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Even with this, I think adding the display of these features into an OMAP-specific section of
/proc/cpuinfowould be even better.
[sp] Single line prints look good. We can also add details in cpuinfo.
~sanjeev
Quoted 49 lines
Comments?
Kevin
commit
24f7422bad970cea2ed71d71e3994eeed70f175fAuthor: Kevin Hilman <[email protected]> Date: Tue Oct 13 14:42:00 2009 -0700OMAP3: collapse chip feature prints to single line
Signed-off-by Kevin Hilman <[email protected]>arch/arm/mach-omap2/id.c +4
-6@@ -249,11 +249,8 @@ void __init omap3_check_revision(void) }#define OMAP3_SHOW_FEATURE (feat) \ - if (omap3_has_ ##feat()) { \ - pr_info (" - "#feat" : Y"); \ - } else { \ - pr_info (" - "#feat" : N"); \ - } + if (omap3_has_ ##feat()) \ + printk (#feat" "); \void __init omap3_cpuinfo (void ) {@@ -307,13 +304,14 @@ void __init omap3_cpuinfo(void)/* * Print verbose information */ -pr_info ("OMAP%s ES%s\n" , cpu_name, cpu_rev); +pr_info ("OMAP%s ES%s (" , cpu_name, cpu_rev);OMAP3_SHOW_FEATURE (l2cache);OMAP3_SHOW_FEATURE (iva);OMAP3_SHOW_FEATURE (sgx);OMAP3_SHOW_FEATURE (neon);OMAP3_SHOW_FEATURE (isp); +printk (")\n" ); }/*
Sanjeev,
Quoted 41 lines
-----Original Message-----
From: [email protected] [mailto:linux-omap- [email protected]] On Behalf Of Premi, Sanjeev
Sent: Wednesday, October 14, 2009 3:26 AM
To: Kevin Hilman; Menon, Nishanth
Cc: [email protected]
Subject: RE: FEATURES printsQuoted 32 lines
-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, October 14, 2009 3:17 AM
To: Menon, Nishanth
Cc: Premi, Sanjeev; [email protected]
Subject: Re: FEATURES printsQuoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : YQuoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Quoted 5 lines
Quoted 3 lines
Even with this, I think adding the display of these features into an OMAP-specific section of
/proc/cpuinfowould be even better.[sp] Single line prints look good. We can also add details in cpuinfo.
If you are ok with proc entry then we don't even need this noise at all in the boot. It's just that adding proc entries is discouraged to some extent.
Regards,
Santosh
Quoted 42 lines · Santosh
Sanjeev,
Quoted 40 lines
-----Original Message-----
From: [email protected] [mailto:linux-omap- [email protected]] On Behalf Of Premi, Sanjeev
Sent: Wednesday, October 14, 2009 3:26 AM
To: Kevin Hilman; Menon, Nishanth
Cc: [email protected]
Subject: RE: FEATURES printsQuoted 31 lines
-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Wednesday, October 14, 2009 3:17 AM
To: Menon, Nishanth
Cc: Premi, Sanjeev; [email protected]
Subject: Re: FEATURES printsQuoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : YQuoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Quoted 6 lines
Quoted 4 lines
Quoted 3 lines
Even with this, I think adding the display of these features into an OMAP-specific section of
/proc/cpuinfowould be even better.[sp] Single line prints look good. We can also add details in cpuinfo.
If you are ok with proc entry then we don't even need this noise at all in the boot. It's just that adding proc entries is discouraged to some extent.
FWIW, I was not thinking adding a new proc entry. I was thinking of extending /proc/cpuinfo with some platform specific entries.
Kevin
Tony Lindgren
maintainerQuoted 21 lines · Kevin Hilman
Quoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : YQuoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Quoted 8 lines
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Even with this, I think adding the display of these features into an OMAP-specific section of
/proc/cpuinfowould be even better.Comments?
I like. Looks like this patch needs to be refreshed.
Tony
Quoted 49 lines
Kevin
commit
24f7422bad970cea2ed71d71e3994eeed70f175fAuthor: Kevin Hilman <[email protected]> Date: Tue Oct 13 14:42:00 2009 -0700OMAP3: collapse chip feature prints to single line
Signed-off-by Kevin Hilman <[email protected]>arch/arm/mach-omap2/id.c +4
-7@@ -249,11 +249,8 @@ void __init omap3_check_revision(void) }#define OMAP3_SHOW_FEATURE (feat) \ - if (omap3_has_ ##feat()) { \ - pr_info (" - "#feat" : Y"); \ - } else { \ - pr_info (" - "#feat" : N"); \ - } + if (omap3_has_ ##feat()) \ + printk (#feat" "); \void __init omap3_cpuinfo (void ) {@@ -307,13 +304,14 @@ void __init omap3_cpuinfo(void)/* * Print verbose information */ -pr_info ("OMAP%s ES%s\n" , cpu_name, cpu_rev); +pr_info ("OMAP%s ES%s (" , cpu_name, cpu_rev);OMAP3_SHOW_FEATURE (l2cache);OMAP3_SHOW_FEATURE (iva);OMAP3_SHOW_FEATURE (sgx);OMAP3_SHOW_FEATURE (neon);OMAP3_SHOW_FEATURE (isp); +printk (")\n" ); }/* -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 26 lines · Tony Lindgren
Quoted 25 lines · Kevin Hilman
Quoted 9 lines · Nishanth Menon
Folks,
With the addition of FEATURES in l-o, the following prints:
- l2cache : Y
- iva : Y
- sgx : Y
- neon : Y
- isp : YQuoted 4 lines
comes up on SDP3430 -> now that we will introduce half a dozen features here and there, we will soon clutter this up. we should introduce a sysfs entry + remove the above noise..
Like Nishanth, I don't like the multi-line noise here. The patch below results in a single line output like this instead
OMAP3430/3530 ES3.0 (l2cache iva sgx neon isp )
Not sure why we need to dump features that are not there, but if that s considered important, maybe prefixing each feature with a '+' or '-' would still allow this to be collapsed into a single line.
Quoted 7 lines
Quoted 4 lines
Even with this, I think adding the display of these features into an OMAP-specific section of
/proc/cpuinfowould be even better.Comments?
I like. Looks like this patch needs to be refreshed.
OK, will send refreshed version.
Kevin