Skip to contentSkip to conversation

ALSA: HDA VIA: Remove 48k sample rate limit for S/PDIF

PATCH In review Logan Li 2 participants 2 messages Oct 14, 2009 Sound

lore
Share & tools
lore

Logan Li

author
#0 lore raw

PATCH 1/1 ALSA: HDA VIA: Remove 48k sample rate limit for S/PDIF

From: Logan Li <[email protected]>
Subject: ALSA: HDA VIA: Remove 48k sample rate limit for S/PDIF

48 kHz limit is for slightly better stability, and sample rates other than 48k (like 96k/192k) are for better sound quality.
We choose better quality, so remove the 48k limit.

---
 sound/pci/hda/patch_via.c |    4 ----
 1 file changed, 4 deletions(-)
sound/pci/hda/patch_via.c +0 -4
@@ -4626,7 +4626,6 @@
 	.substreams = 2,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5124,7 +5123,6 @@
 	.substreams = 2,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5561,7 +5559,6 @@
 	.substreams = 1,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5914,7 +5911,6 @@
 	.substreams = 1,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
#1 lore raw

At Wed, 14 Oct 2009 10:10:38 +0800,

Quoted 9 lines · Logan Li

From: Logan Li <[email protected]>
Subject: ALSA: HDA VIA: Remove 48k sample rate limit for S/PDIF

48 kHz limit is for slightly better stability, and sample rates other than 48k (like 96k/192k) are for better sound quality.
We choose better quality, so remove the 48k limit.

Applied now. Thanks!

Takashi

Quoted 40 lines
---
 sound/pci/hda/patch_via.c |    4 ----
 1 file changed, 4 deletions(-)
sound/pci/hda/patch_via.c +0 -4
@@ -4626,7 +4626,6 @@
 	.substreams = 2,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5124,7 +5123,6 @@
 	.substreams = 2,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5561,7 +5559,6 @@
 	.substreams = 1,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,
@@ -5914,7 +5911,6 @@
 	.substreams = 1,
 	.channels_min = 2,
 	.channels_max = 2,
-	.rates = SNDRV_PCM_RATE_48000,
 	/* NID is set in via_build_pcms */
 	.ops = {
 		.open = via_dig_playback_pcm_open,