Skip to contentSkip to conversation

2.6.32 regression: can't tune DVB with firedtv

PATCH In review Stefan Richter 2 participants 6 messages Oct 17, 2009 – Nov 13, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi list,

I just switched from kernel 2.6.31 to 2.6.32-rc5. Using kaffeine, I can't tune FireDTV-C and FireDTV-T boxes via the firedtv driver anymore. Electronic program guide data is still displayed though.

Under 2.6.31, I used firedtv at the same patchlevel as present in 2.6.32-rc5, hence I guess that it is a DVB core problem rather than a driver problem.

Any suggestions where to look for the cause?

(I am not subscribed to the list.)

Signature · 3 lines
Stefan Richter
-=====-==--= =-=- =---=
http://arcgraph.de/sr/
#1 lore raw
Quoted 11 lines · Stefan Richter

I just switched from kernel 2.6.31 to 2.6.32-rc5. Using kaffeine, I can't tune FireDTV-C and FireDTV-T boxes via the firedtv driver anymore. Electronic program guide data is still displayed though.

Under 2.6.31, I used firedtv at the same patchlevel as present in 2.6.32-rc5, hence I guess that it is a DVB core problem rather than a driver problem.

Any suggestions where to look for the cause?

From looking at the git history of dvb-core, I think the cause is

"V4L/DVB (12685): dvb-core: check fe->ops.set_frontend return value", but the actual bug is in the driver in firedtv-fe.c::fdtv_set_frontend(). Let me boot back into 2.6.32-rc5 and check my theory...

Quoted 1 line

(I am not subscribed to the list.)

Signature · 3 lines
Stefan Richter
-=====-==--= =-=- =---=
http://arcgraph.de/sr/
#2 lore raw

PATCH 1/1 firedtv: fix regression: tuning fails due to bogus error return

Since 2.6.32(-rc1), DVB core checks the return value of dvb_frontend_ops.set_frontend. Now it becomes apparent that firedtv always returned a bogus value from its set_frontend method.

---
 drivers/media/dvb/firewire/firedtv-avc.c |    7 +++++--
 drivers/media/dvb/firewire/firedtv-fe.c  |    8 +-------
 2 files changed, 6 insertions(+), 9 deletions(-)
drivers/media/dvb/firewire/firedtv-avc.c +5 -2
Index: linux-2.6.32-rc5/drivers/media/dvb/firewire/firedtv-avc.c
===================================================================
@@ -573,8 +573,11 @@ int avc_tuner_dsd(struct firedtv *fdtv,
 
 	msleep(500);
 #if 0
-	/* FIXME: */
-	/* u8 *status was an out-parameter of avc_tuner_dsd, unused by caller */
+	/*
+	 * FIXME:
+	 * u8 *status was an out-parameter of avc_tuner_dsd, unused by caller
+	 * Check for AVC_RESPONSE_ACCEPTED here instead?
+	 */
 	if (status)
 		*status = r->operand[2];
 #endif
drivers/media/dvb/firewire/firedtv-fe.c +1 -7
Index: linux-2.6.32-rc5/drivers/media/dvb/firewire/firedtv-fe.c
===================================================================
@@ -141,18 +141,12 @@ static int fdtv_read_uncorrected_blocks(
 	return -EOPNOTSUPP;
 }
 
-#define ACCEPTED 0x9
-
 static int fdtv_set_frontend(struct dvb_frontend *fe,
 			     struct dvb_frontend_parameters *params)
 {
 	struct firedtv *fdtv = fe->sec_priv;
 
-	/* FIXME: avc_tuner_dsd never returns ACCEPTED. Check status? */
-	if (avc_tuner_dsd(fdtv, params) != ACCEPTED)
-		return -EINVAL;
-	else
-		return 0; /* not sure of this... */
+	return avc_tuner_dsd(fdtv, params);
 }
 
 static int fdtv_get_frontend(struct dvb_frontend *fe,
Signature · 3 lines
Stefan Richter
-=====-==--= =-=- =---=
http://arcgraph.de/sr/
#3 lore raw

Re: [PATCH] firedtv: fix regression: tuning fails due to bogus error return

Stefan Richter wrote on 2009-10-17:

Quoted 5 lines

Since 2.6.32(-rc1), DVB core checks the return value of dvb_frontend_ops.set_frontend. Now it becomes apparent that firedtv always returned a bogus value from its set_frontend method.

Hi Mauro,

when you committed this, you added "CC: [email protected]". This is not necessary, 2.6.32-rc1 is the first kernel version with the regression (see changelog).

Well, OK, the patch would become necessary in -stable if somebody was to put the new set_frontend return code check in dvb core into -stable. But I hope nobody is going to do that; it'd be a bad idea.

Furthermore...

Quoted 13 lines
---
 drivers/media/dvb/firewire/firedtv-avc.c |    7 +++++--
 drivers/media/dvb/firewire/firedtv-fe.c  |    8 +-------
 2 files changed, 6 insertions(+), 9 deletions(-)

Index: linux-2.6.32-rc5/drivers/media/dvb/firewire/firedtv-avc.c
===================================================================

drivers/media/dvb/firewire/firedtv-avc.c +0 -0
@@ -573,8 +573,11 @@ int avc_tuner_dsd(struct firedtv *fdtv,
 
 	msleep(500);
 #if 0

drivers/media/dvb/firewire/firedtv-avc.c int avc_tuner_dsd(struct firedtv *fdtv, · line 583

Quoted 10 lines
drivers/media/dvb/firewire/firedtv-avc.c +5 -2
-	/* FIXME: */
-	/* u8 *status was an out-parameter of avc_tuner_dsd, unused by caller */
+	/*
+	 * FIXME:
+	 * u8 *status was an out-parameter of avc_tuner_dsd, unused by caller
+	 * Check for AVC_RESPONSE_ACCEPTED here instead?
+	 */
 	if (status)
 		*status = r->operand[2];
 #endif

...the firedtv-avc.c part of the patch vanished when you committed it. I guess this was accident, not deliberate --- otherwise a note in the changelog below of my Signed-off-by would have been appreciated.

I will resubmit this missing comment change or a variation of it or even a fix of the FIXME sometime in the future.

Quoted 25 lines

Index: linux-2.6.32-rc5/drivers/media/dvb/firewire/firedtv-fe.c
===================================================================

drivers/media/dvb/firewire/firedtv-fe.c +1 -7
@@ -141,18 +141,12 @@ static int fdtv_read_uncorrected_blocks(
 	return -EOPNOTSUPP;
 }
 
-#define ACCEPTED 0x9
-
 static int fdtv_set_frontend(struct dvb_frontend *fe,
 			     struct dvb_frontend_parameters *params)
 {
 	struct firedtv *fdtv = fe->sec_priv;
 
-	/* FIXME: avc_tuner_dsd never returns ACCEPTED. Check status? */
-	if (avc_tuner_dsd(fdtv, params) != ACCEPTED)
-		return -EINVAL;
-	else
-		return 0; /* not sure of this... */
+	return avc_tuner_dsd(fdtv, params);
 }
 
 static int fdtv_get_frontend(struct dvb_frontend *fe,
Signature · 3 lines
Stefan Richter
-=====-==--= =-== -==-=
http://arcgraph.de/sr/
#4 lore raw

Re: [PATCH] firedtv: fix regression: tuning fails due to bogus error return

Quoted 1 line · Stefan Richter

...the firedtv-avc.c part of the patch vanished when you committed it.

It was still there in the linuxtv-commits message of the respective Mercurial commit, BTW. Something wrong with the hg to git workflow?

Signature · 3 lines
Stefan Richter
-=====-==--= =-== -==-=
http://arcgraph.de/sr/
#5 lore raw
In reply to Stefan Richter

Am Sat, 17 Oct 2009 21:01:50 +0200
schrieb Stefan Richter <[email protected]>:

Quoted 6 lines

Hi list,

I just switched from kernel 2.6.31 to 2.6.32-rc5. Using kaffeine, I can't tune FireDTV-C and FireDTV-T boxes via the firedtv driver anymore. Electronic program guide data is still displayed though.

Quoted 7 lines

Under 2.6.31, I used firedtv at the same patchlevel as present in 2.6.32-rc5, hence I guess that it is a DVB core problem rather than a driver problem.

Any suggestions where to look for the cause?

(I am not subscribed to the list.)

Hi there,

perhaps it is related:
with kernel 2.6.30.8 my "TwinhanDTV USB-Ter USB1.1 / Magic Box I" worked.

Now with kernel 2.6.32-rc3 (and 2.6.31.1) the modules seems to be loaded fine, but tzap/kaffeine/mplayer can not tune to a channel.

i think the cause must be here:
/usr/src/linux-2.6.32-rc3/drivers/media/dvb/dvb-usb/dibusb-common.c line 136 to line 146

i changed this hole section to the version of 2.6.30.8 and it works again.

Mario