Skip to contentSkip to conversation

question on SCTP_DELAYED_ACK and sctp_sack_info

DISCUSSION Chris Friesen 2 participants 2 messages Oct 20, 2009 SCTP protocol

lore
Share & tools
lore
#0 lore raw

Hi all,

I've got a question about the handling of SCTP_DELAYED_ACK.

In sctp_setsockopt_delayed_ack() the code looks to see if the size of the struct being passed down matches the size of struct sctp_sack_info.
If it doesn't, it accepts being passed struct sctp_assoc_value but it
complains about it.

However, the lksctp-tools package doesn't seem to define or use struct sctp_sack_info anywhere, only struct sctp_assoc_value.

Are apps expected to copy the struct definition themselves? Is there any plan to update lksctp-tools?

Thanks,

Chris

#1 lore raw
Quoted 9 lines · Chris Friesen

Hi all,

I've got a question about the handling of SCTP_DELAYED_ACK.

In sctp_setsockopt_delayed_ack() the code looks to see if the size of the struct being passed down matches the size of struct sctp_sack_info.
If it doesn't, it accepts being passed struct sctp_assoc_value but it
complains about it.

Quoted 5 lines

However, the lksctp-tools package doesn't seem to define or use struct sctp_sack_info anywhere, only struct sctp_assoc_value.

Are apps expected to copy the struct definition themselves? Is there any plan to update lksctp-tools?

Yes. I have to get my a** in gear and do a release.

If you pull the sources from
git://git.kernel.org/pub/scm/linux/kernel/git/vxy/lksctp-tools.git

you'll get an updated one.

I am going to spend some time tomorrow to get that code out.

Thanks for a kick in the pants
-vlad

Quoted 9 lines

Thanks,

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html