Skip to contentSkip to conversation

mem/hugetlb: fix failure of hugemmap03

PATCH In review liubo 2 participants 2 messages Oct 21, 2009 – Oct 26, 2009

lore
Share & tools
lore

liubo

author
#0 lore raw

PATCH 1/1 mem/hugetlb: fix failure of hugemmap03

1) In mmap's manual,
The starting address for the new mapping is specified in addr.

So, if mmap's argument "addr" is reachable, the mmap will creates a new mapping in the virtual address space of the call-ing process.
The test hugemmap03 will test that a normal page cannot
be mapped into a high memory region. This infers that "addr"
should be higher for 64-bit mode.

2) The test use "-I2" option, and this not only causes TFAIL's
loop, but also causes TPASS's loop.
For TFAIL, loop is deserved, nor for TPASS.

This patch fixed these problems.

---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c +2 -1
index 892d24b..a07b9aa 100644
@@ -55,7 +55,7 @@
 #include "usctest.h"
 
 #define PAGE_SIZE      ((1UL) << 12) 	/* Normal page size */
-#define HIGH_ADDR      (void *)(0x10000000000)
+#define HIGH_ADDR      (void *)(0x1000000000000)
 
 char* TEMPFILE="mmapfile";
 
@@ -130,6 +130,7 @@ main(int ac, char **av)
 			continue;
 		} else {
 			tst_resm(TPASS, "Normal mmap() into high region failed correctly");
+			break;
 		}
 
 		close(fildes);

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 11 lines · liubo

1) In mmap's manual,
The starting address for the new mapping is specified in addr.

So, if mmap's argument "addr" is reachable, the mmap will creates a new mapping in the virtual address space of the call-ing process.
The test hugemmap03 will test that a normal page cannot
be mapped into a high memory region. This infers that "addr"
should be higher for 64-bit mode.

Quoted 7 lines

2) The test use "-I2" option, and this not only causes TFAIL's
loop, but also causes TPASS's loop.
For TFAIL, loop is deserved, nor for TPASS.

This patch fixed these problems.

Thanks.

Regards--
Subrata

Quoted 32 lines
---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c +2 -2
index 892d24b..a07b9aa 100644
@@ -55,7 +55,7 @@
 #include "usctest.h"
 
 #define PAGE_SIZE      ((1UL) << 12) 	/* Normal page size */
-#define HIGH_ADDR      (void *)(0x10000000000)
+#define HIGH_ADDR      (void *)(0x1000000000000)
 
 char* TEMPFILE="mmapfile";
 
@@ -130,6 +130,7 @@ main(int ac, char **av)
 			continue;
 		} else {
 			tst_resm(TPASS, "Normal mmap() into high region failed correctly");
+			break;
 		}
 
 		close(fildes);
 
 
 
 
------------------------------------------------------------------------------

Come build with us! The BlackBerry(R) Developer Conference in SF, CA

Quoted 8 lines

is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list