Skip to contentSkip to conversation

interrupt remapping fix

PATCH New Zhai, Edwin 1 participant 1 message Oct 23, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 interrupt remapping fix

Fix the error of translation from int remapping table entry(IRTE) to MSI msg. This error may write wrong IRTE back to the VTd hardware, and block physical interrupts.

Signature · 2 lines
best rgds,
edwin
xen/drivers/passthrough/vtd/intremap.c +6 -2
Index: xen-dev/xen/drivers/passthrough/vtd/intremap.c
===================================================================
@@ -468,8 +468,12 @@ static int remap_entry_to_msi_msg(
             MSI_ADDR_DESTMODE_LOGIC) |
         ((iremap_entry->lo.dlm != dest_LowestPrio) ?
             MSI_ADDR_REDIRECTION_CPU:
-            MSI_ADDR_REDIRECTION_LOWPRI) |
-        iremap_entry->lo.dst >> 8;
+            MSI_ADDR_REDIRECTION_LOWPRI);
+    if ( x2apic_enabled )
+        msg->dest32 = iremap_entry->lo.dst;
+    else
+        msg->address_lo |=
+            ((iremap_entry->lo.dst >> 8) & 0xff ) << MSI_ADDR_DEST_ID_SHIFT;
 
     msg->data =
         MSI_DATA_TRIGGER_EDGE |

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel