net: Cleanup redundant tests on unsigned

PATCH Applied Roel Kluin 2 participants 2 messages Oct 23, 2009 – Oct 29, 2009

Subsystems (3)

Networking Network drivers X.25 stack

lore

Share & tools

lore

Roel Kluin

author

2009-10-23 15:21 UTC #0 lore raw

PATCH 1/1 net: Cleanup redundant tests on unsigned

If there is data, the unsigned skb->len is greater than 0.

rt.sigdigits is unsigned as well, so the test `>= 0' is always true, the other part of the test catches wrapped values.

Signed-off-by Roel Kluin <[email protected]>

---
 net/x25/x25_in.c    |    2 +-
 net/x25/x25_route.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

net/x25/x25_in.c +1 -1

index 7d7c3ab..96d9227 100644
@@ -114,7 +114,7 @@ static int x25_state1_machine(struct sock *sk, struct sk_buff *skb, int frametyp
 			/*
 			 *	Copy any Call User Data.
 			 */
-			if (skb->len >= 0) {
+			if (skb->len > 0) {
 				skb_copy_from_linear_data(skb,
 					      x25->calluserdata.cuddata,
 					      skb->len);

net/x25/x25_route.c +1 -1

index 2c999cc..66961ea 100644
@@ -190,7 +190,7 @@ int x25_route_ioctl(unsigned int cmd, void __user *arg)
 		goto out;
 
 	rc = -EINVAL;
-	if (rt.sigdigits < 0 || rt.sigdigits > 15)
+	if (rt.sigdigits > 15)
 		goto out;
 
 	dev = x25_dev_get(rt.device);

David Miller

maintainer Applied

2009-10-29 08:40 UTC #1 lore raw

From: Roel Kluin <[email protected]>
Date: Fri, 23 Oct 2009 17:21:56 +0200

Quoted 7 lines

If there is data, the unsigned skb->len is greater than 0.
rt.sigdigits is unsigned as well, so the test `>= 0' is always true, the other part of the test catches wrapped values.
Signed-off-by Roel Kluin <[email protected]>

Applied.