CacheFiles: Cleanup redundant tests on unsigned
PATCH 1/1 CacheFiles: Cleanup redundant tests on unsigned
The variables are unsigned so the test >= 0' is always true, the < 0' test always fails. The other part of
the test catches wrapped values.
Signed-off-by Roel Kluin <[email protected]>
--- fs/cachefiles/bind.c | 6 ++---- fs/cachefiles/daemon.c | 6 +++--- 2 files changed, 5 insertions(+), 7 deletions(-)
fs/cachefiles/bind.c +2 -4
@@ -39,13 +39,11 @@ int cachefiles_daemon_bind(struct cachefiles_cache *cache, char *args) args);/* start by checking things over */ -ASSERT (cache->fstop_percent >=0 && - cache->fstop_percent < cache->fcull_percent && +ASSERT (cache->fstop_percent < cache->fcull_percent && cache->fcull_percent < cache->frun_percent && cache->frun_percent <100 ); -ASSERT (cache->bstop_percent >=0 && - cache->bstop_percent < cache->bcull_percent && +ASSERT (cache->bstop_percent < cache->bcull_percent && cache->bcull_percent < cache->brun_percent && cache->brun_percent <100 );
fs/cachefiles/daemon.c +3 -3
@@ -220,7 +220,7 @@ static ssize_t cachefiles_daemon_write(struct file *file,if (test_bit (CACHEFILES_DEAD , &cache->flags))return -EIO ; -if (datalen <0 || datalen >PAGE_SIZE -1 ) +if (datalen >PAGE_SIZE -1 )return -EOPNOTSUPP ;/* drag the command string into the kernel so we can parse it */
@@ -385,7 +385,7 @@ static int cachefiles_daemon_fstop(struct cachefiles_cache *cache, char *args)if (args[0 ] !='%' || args[1 ] !='\0' )return -EINVAL ; -if (fstop <0 || fstop >= cache->fcull_percent) +if (fstop >= cache->fcull_percent)return cachefiles_daemon_range_error (cache, args); cache->fstop_percent = fstop;
@@ -457,7 +457,7 @@ static int cachefiles_daemon_bstop(struct cachefiles_cache *cache, char *args)if (args[0 ] !='%' || args[1 ] !='\0' )return -EINVAL ; -if (bstop <0 || bstop >= cache->bcull_percent) +if (bstop >= cache->bcull_percent)return cachefiles_daemon_range_error (cache, args); cache->bstop_percent = bstop;