failure to submit first post

DISCUSSION KS Ng 2 participants 4 messages Oct 25, 2009 – Oct 27, 2009 Media (V4L/DVB)

Share & tools

KS Ng

author

2009-10-25 13:35 UTC #0 lore raw

Hi,

I've registered to linux-media mailing list a couple of days ago and attempted to do my first posting yesterday with subject "Support for Magicpro proHDTV Dual DMB-TH adapter". However I can't see my posting even though I've replied to the email requesting confirmation.

Would you please kindly have a look!

Thanks,
K.S. Ng

email: [email protected]

KS Ng

author

2009-10-26 13:24 UTC #1 lore raw

This is a resend with the patch attached.

Quoted 10 lines · KS Ng

Hi,
I've registered to linux-media mailing list a couple of days ago and attempted to do my first posting yesterday with subject "Support for Magicpro proHDTV Dual DMB-TH adapter". However I can't see my posting even though I've replied to the email requesting confirmation.
Would you please kindly have a look!
Thanks,
K.S. Ng
email: [email protected]

linux/drivers/media/common/tuners/Kconfig +7 -0

diff -r f6680fa8e7ec linux/drivers/media/common/tuners/Kconfig
@@ -172,4 +172,11 @@
 	help
 	  Say Y here to support the Freescale MC44S803 based tuners
 
+config MEDIA_TUNER_MPDUAL
+	tristate "Tuner for Magicpro proHDTV Dual DMB-TH adapter"
+	depends on VIDEO_MEDIA && I2C
+	default m if MEDIA_TUNER_CUSTOMISE
+	help
+	  Say Y here to support Magicpro proHDTV Dual adapter
+
 endif # MEDIA_TUNER_CUSTOMISE

linux/drivers/media/common/tuners/Makefile +1 -0

diff -r f6680fa8e7ec linux/drivers/media/common/tuners/Makefile
@@ -23,6 +23,7 @@
 obj-$(CONFIG_MEDIA_TUNER_MXL5005S) += mxl5005s.o
 obj-$(CONFIG_MEDIA_TUNER_MXL5007T) += mxl5007t.o
 obj-$(CONFIG_MEDIA_TUNER_MC44S803) += mc44s803.o
+obj-$(CONFIG_MEDIA_TUNER_MPDUAL) += tuner-mpdual.o
 
 EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
 EXTRA_CFLAGS += -Idrivers/media/dvb/frontends

linux/drivers/media/common/tuners/tuner-mpdual.c new file +669 -0

669 lines not on this page · raw message

linux/drivers/media/common/tuners/tuner-mpdual.h new file +79 -0

79 lines not on this page · raw message

linux/drivers/media/dvb/dvb-usb/cxusb.c +113 -0

167 lines not on this page · raw message

linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h +1 -0

diff -r f6680fa8e7ec linux/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -86,6 +86,7 @@
 #define USB_PID_COMPRO_VIDEOMATE_U500_PC		0x1e80
 #define USB_PID_CONCEPTRONIC_CTVDIGRCU			0xe397
 #define USB_PID_CONEXANT_D680_DMB			0x86d6
+#define USB_PID_CONEXANT_D680_DMB2			0x8695
 #define USB_PID_DIBCOM_HOOK_DEFAULT			0x0064
 #define USB_PID_DIBCOM_HOOK_DEFAULT_REENUM		0x0065
 #define USB_PID_DIBCOM_MOD3000_COLD			0x0bb8

linux/drivers/media/dvb/frontends/lgs8gxx.c +1 -0

diff -r f6680fa8e7ec linux/drivers/media/dvb/frontends/lgs8gxx.c
@@ -266,6 +266,7 @@
 		lgs8gxx_write_reg(priv, 0x39, 0x00);
 		lgs8gxx_write_reg(priv, 0x3D, 0x04);
 	} else if (prod == LGS8GXX_PROD_LGS8913 ||
+		prod == LGS8GXX_PROD_MP_HDTV_DUAL ||
 		prod == LGS8GXX_PROD_LGS8GL5 ||
 		prod == LGS8GXX_PROD_LGS8G42 ||
 		prod == LGS8GXX_PROD_LGS8G52 ||

linux/drivers/media/dvb/frontends/lgs8gxx.h +1 -0

diff -r f6680fa8e7ec linux/drivers/media/dvb/frontends/lgs8gxx.h
@@ -35,6 +35,7 @@
 #define LGS8GXX_PROD_LGS8G52 4
 #define LGS8GXX_PROD_LGS8G54 5
 #define LGS8GXX_PROD_LGS8G75 6
+#define LGS8GXX_PROD_MP_HDTV_DUAL 7
 
 struct lgs8gxx_config {

Mauro Carvalho Chehab

2009-10-27 10:12 UTC #2 lore raw

Em Mon, 26 Oct 2009 21:24:03 +0800
KS Ng <[email protected]> escreveu:

Quoted 11 lines

This is a resend with the patch attached.
Quoted 8 lines · KS Ng
Hi,
I've registered to linux-media mailing list a couple of days ago and attempted to do my first posting yesterday with subject "Support for Magicpro proHDTV Dual DMB-TH adapter". However I can't see my posting even though I've replied to the email requesting confirmation.
Would you please kindly have a look!

Please take a look at:
http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches

for some comments about how to submit a patch.

Basically, you'll need to send a patch with a short description at the subject, a more complete description at the body and add your Signed-off-by: there.

Also, please run checkpatch before submitting it, since it will point you the CodingStyle troubles that your code have. There are several coding styles there, being harder for people to analyse your code.

In the case of tuner_init_pkts, is this a firmware or just register sets? If it is a firmware, it should be split from the code, due to legal issues. Basically, some lawyers believe that, if you distribute a firmware inside of the source code of a GPL'd code, you're bound to distribute also the firmware source code, due to GPL.

Cheers,
Mauro.

Quoted 6 lines

Quoted 5 lines
Thanks,
K.S. Ng
email: [email protected]

Cheers,
Mauro

KS Ng

author

2009-10-27 11:42 UTC #3 lore raw

Hi Mauro,

Thanks for your attention! I also believe packets under tuner_init_pkts constitute the firmware of the device. I'll see how to construct a firmware file instead of coding them inline, and I'll re-submit once I've figured that out.

Cheers,
K.S. Ng

Quoted 49 lines · Mauro Carvalho Chehab

Em Mon, 26 Oct 2009 21:24:03 +0800
KS Ng <[email protected]> escreveu:
Quoted 10 lines
This is a resend with the patch attached.
Quoted 6 lines · KS Ng
Hi,
I've registered to linux-media mailing list a couple of days ago and attempted to do my first posting yesterday with subject "Support for Magicpro proHDTV Dual DMB-TH adapter". However I can't see my posting even though I've replied to the email requesting confirmation.
Would you please kindly have a look!
Please take a look at:
http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches
for some comments about how to submit a patch.
Basically, you'll need to send a patch with a short description at the subject, a more complete description at the body and add your Signed-off-by: there.
Also, please run checkpatch before submitting it, since it will point you the CodingStyle troubles that your code have. There are several coding styles there, being harder for people to analyse your code.
In the case of tuner_init_pkts, is this a firmware or just register sets? If it is a firmware, it should be split from the code, due to legal issues. Basically, some lawyers believe that, if you distribute a firmware inside of the source code of a GPL'd code, you're bound to distribute also the firmware source code, due to GPL.
Cheers,
Mauro.
Quoted 5 lines
Quoted 5 lines
Thanks,
K.S. Ng
email: [email protected]
Cheers,
Mauro