Skip to contentSkip to conversation

r8169: Fix card drop incoming VLAN tagged MTU byte large jumbo frames

PATCH Applied Raimonds Cicans 2 participants 2 messages Oct 26, 2009 – Oct 30, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Raimonds Cicans

author
#0 lore raw

r8169 card drop incoming VLAN tagged MTU byte large jumbo frames

It looks to compare current and maximal packet sizes hardware use '<' operator, not '<='.

Bug introduced by patch:
r8169: fix crash when large packets are received

Signed-off-by Raimonds Cicans <[email protected]>

---

drivers/net/r8169.c renamed from drivers/net/r8169.c.orig +1 -1
@@ -2365,7 +2365,7 @@ static u16 rtl_rw_cpluscmd(void __iomem 
 static void rtl_set_rx_max_size(void __iomem *ioaddr, unsigned int rx_buf_sz)
 {
 	/* Low hurts. Let's disable the filtering. */
-	RTL_W16(RxMaxSize, rx_buf_sz);
+	RTL_W16(RxMaxSize, rx_buf_sz + 1);
 }
 
 static void rtl8169_set_magic_reg(void __iomem *ioaddr, unsigned mac_version)
maintainer Applied
#1 lore raw

From: Raimonds Cicans <[email protected]>
Date: Mon, 26 Oct 2009 22:52:37 +0200

Quoted 9 lines

r8169 card drop incoming VLAN tagged MTU byte large jumbo frames

It looks to compare current and maximal packet sizes hardware use '<' operator, not '<='.

Bug introduced by patch:
r8169: fix crash when large packets are received

Signed-off-by Raimonds Cicans <[email protected]>

Applied, thank you.