Skip to contentSkip to conversation

tracing: Fix to use unused attribute

PATCH In review Li Zefan 2 participants 2 messages Oct 28, 2009 – Oct 29, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 tracing: Fix to use unused attribute

____ftrace_check_##name() is used for compile-time check on F_printk() only, so it should be marked as __unused instead of __used.

---

I'm thinking about introducing __always_unused, comparing to __maybe_unused.

---
 kernel/trace/trace_export.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
kernel/trace/trace_export.c +3 -2
index 934d81f..85309fc 100644
@@ -48,11 +48,12 @@
 struct ____ftrace_##name {					\
 	tstruct							\
 };								\
-static void __used ____ftrace_check_##name(void)		\
+static void __attribute__((unused))				\
+____ftrace_check_##name(void)					\
 {								\
 	struct ____ftrace_##name *__entry = NULL;		\
 								\
-	/* force cmpile-time check on F_printk() */		\
+	/* force compile-time check on F_printk() */		\
 	printk(print);						\
 }
 
Signature · 1 line
1.6.3
#1 lore raw
Quoted 22 lines · Li Zefan

____ftrace_check_##name() is used for compile-time check on F_printk() only, so it should be marked as __unused instead of __used.

---

I'm thinking about introducing __always_unused, comparing to __maybe_unused.

---
 kernel/trace/trace_export.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
kernel/trace/trace_export.c +0 -0
index 934d81f..85309fc 100644
@@ -48,11 +48,12 @@
 struct ____ftrace_##name {					\
 	tstruct							\
 };								\

kernel/trace/trace_export.c line 58

Quoted 10 lines
kernel/trace/trace_export.c +3 -2
-static void __used ____ftrace_check_##name(void)		\
+static void __attribute__((unused))				\
+____ftrace_check_##name(void)					\
 {								\
 	struct ____ftrace_##name *__entry = NULL;		\
 								\
-	/* force cmpile-time check on F_printk() */		\
+	/* force compile-time check on F_printk() */		\
 	printk(print);						\
 }

Hm, open-coding __attribute__()'s is not good.

These tags are somewhat of a mess:

#if __GNUC_MINOR__ >= 3

 # define __used                 __attribute__((__used__))
 #else
 # define __used                 __attribute__((__unused__))
 #endif

I've Cc:-ed Linus and Andrew, to solicite feedback on __always_unused. I think we should add it.

Ingo